From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57364)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZSfka-0005kA-OQ
	for qemu-devel@nongnu.org; Fri, 21 Aug 2015 02:24:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZSfkZ-0006oj-2E
	for qemu-devel@nongnu.org; Fri, 21 Aug 2015 02:24:27 -0400
References: <1440111638-30188-1-git-send-email-mreitz@redhat.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55D6C401.6050003@redhat.com>
Date: Thu, 20 Aug 2015 23:24:01 -0700
MIME-Version: 1.0
In-Reply-To: <1440111638-30188-1-git-send-email-mreitz@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="4UvjSVA7KtoMFsIUUs2ufiVUP4fv0uO8T"
Subject: Re: [Qemu-devel] [PATCH v2] qemu-img: Fix crash in amend invocation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--4UvjSVA7KtoMFsIUUs2ufiVUP4fv0uO8T
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 08/20/2015 04:00 PM, Max Reitz wrote:
> Example:
> $ ./qemu-img create -f qcow2 /tmp/t.qcow2 64M
> $ ./qemu-img amend -f qcow2 -o backing_file=3D/tmp/t.qcow2, -o help \
>     /tmp/t.qcow2
>=20
> This should not crash. This actually is tested by iotest 082, but not
> caught due to the segmentation fault being silent (which is something
> that needs to be fixed, too).
>=20
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: qemu-stable <qemu-stable@nongnu.org>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> v2:
> - Fix leak introduced by trying to be clever [Eric]
>   (thank you for catching this!)
> ---
>  qemu-img.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--4UvjSVA7KtoMFsIUUs2ufiVUP4fv0uO8T
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJV1sQBAAoJEKeha0olJ0Nqz/QIAJ3ISNu8Pl3M007w/g/6wvJm
sP9plyfQDIX2mChVppwVpMPXFAv/YPNYW+wPnN3EmD+EVJibFgmMXCsXQYrzCaMo
OSZvRzD80vpuZ7KYLf0sIo2CnBCvpdzFtkPAtOf0cHms2YwE4JN/SnIPu5NIUpRr
UiZI7gkDvY9fFjEWjFkFsKBm1FeRHq+IbVlw4NWVq8oFP5OYBVRes+Ir0jU4JGAD
PG+BTzz7qSgldK2/DuHAGJm6sTGUCl6zYd0P/X0wIo7krLJ0/NGBPbtDKylYzIbC
EhJq1xhF6n9DSb91ZPFucGAUqRRq3qUq4aztFxxrC2BQ7wdSaaUx7dkwcoGZKnY=
=pNgt
-----END PGP SIGNATURE-----

--4UvjSVA7KtoMFsIUUs2ufiVUP4fv0uO8T--