Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

On 08/20/2015 10:09 AM, gchen gchen wrote:

In the subject line,
s/Firstly add/Add/

('Firstly' is seldom used in English, and certainly not in the context
you were trying to use it)

> They are based on Linux kernel tilegx architecture for 64 bit binary,
> and also based on tilegx ABI reference document, and also reference from
> other targets implementations.

s/targets/targets'/

> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---

> --- /dev/null
> +++ b/linux-user/tilegx/syscall.h
> @@ -0,0 +1,40 @@
> +#ifndef TILEGX_SYSCALLS_H
> +#define TILEGX_SYSCALLS_H
> +
> +#define UNAME_MACHINE "tilegx"
> +#define UNAME_MINIMUM_RELEASE "3.19"

New files should have a copyright license, particularly if the license
differs from the default of GPLv2+.

> --- /dev/null
> +++ b/linux-user/tilegx/syscall_nr.h
> @@ -0,0 +1,324 @@
> +#ifndef TILEGX_SYSCALL_NR
> +#define TILEGX_SYSCALL_NR
> +
> +/*
> + * Copy from linux kernel asm-generic/unistd.h, which tilegx uses.

and since you appear to be copying from the kernel (which is often
GPLv2-only rather than GPLv2+), it matters.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]