From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTbbi-0001tO-Be for qemu-devel@nongnu.org; Sun, 23 Aug 2015 16:11:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTbbe-0007SA-OF for qemu-devel@nongnu.org; Sun, 23 Aug 2015 16:11:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTbbe-0007S2-JX for qemu-devel@nongnu.org; Sun, 23 Aug 2015 16:11:06 -0400 Message-ID: <55DA28C5.7070608@redhat.com> Date: Sun, 23 Aug 2015 16:10:45 -0400 From: Thomas Huth MIME-Version: 1.0 References: <1440132205-7814-1-git-send-email-yanghy@cn.fujitsu.com> <1440132205-7814-4-git-send-email-yanghy@cn.fujitsu.com> In-Reply-To: <1440132205-7814-4-git-send-email-yanghy@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 RESEND 03/11] netfilter: add netfilter_{add|del} commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, Markus Armbruster , mrhines@linux.vnet.ibm.com, Luiz Capitulino , stefanha@redhat.com On 21/08/15 00:43, Yang Hongyang wrote: > add netfilter_{add|del} commands > This is mostly the same with netdev_{add|del} commands. > > When we delete the netdev, we also delete the netfilter object > attached to it, because if the netdev is removed, the filters > which attached to it is useless. > > Signed-off-by: Yang Hongyang > CC: Luiz Capitulino > CC: Markus Armbruster > CC: Eric Blake > --- > v7: error msg fix > move qmp_opts_del() into qemu_del_net_filter() > v6: add multiqueue support (qemu_del_net_filter) > v5: squash "net: delete netfilter object when delete netdev" > --- > hmp-commands.hx | 30 +++++++++++++++ > hmp.c | 29 +++++++++++++++ > hmp.h | 4 ++ > include/net/filter.h | 3 ++ > monitor.c | 33 +++++++++++++++++ > net/filter.c | 101 ++++++++++++++++++++++++++++++++++++++++++++++++++- > net/net.c | 7 ++++ > qapi-schema.json | 47 ++++++++++++++++++++++++ > qmp-commands.hx | 57 +++++++++++++++++++++++++++++ > 9 files changed, 310 insertions(+), 1 deletion(-) Looks sane to me. Reviewed-by: Thomas Huth