From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZTbpg-0007A9-42
	for qemu-devel@nongnu.org; Sun, 23 Aug 2015 16:25:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZTbpc-0004kF-Uo
	for qemu-devel@nongnu.org; Sun, 23 Aug 2015 16:25:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49675)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZTbpc-0004k4-PA
	for qemu-devel@nongnu.org; Sun, 23 Aug 2015 16:25:32 -0400
Message-ID: <55DA2C04.6000404@redhat.com>
Date: Sun, 23 Aug 2015 16:24:36 -0400
From: Thomas Huth <thuth@redhat.com>
MIME-Version: 1.0
References: <1440132205-7814-1-git-send-email-yanghy@cn.fujitsu.com>
	<1440132205-7814-11-git-send-email-yanghy@cn.fujitsu.com>
In-Reply-To: <1440132205-7814-11-git-send-email-yanghy@cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 RESEND 10/11] filter/buffer: update
 command description and help
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, Markus Armbruster <armbru@redhat.com>, mrhines@linux.vnet.ibm.com, Luiz Capitulino <lcapitulino@redhat.com>, stefanha@redhat.com

On 21/08/15 00:43, Yang Hongyang wrote:
> now that we have a buffer netfilter, update the command
> description and help.
> 
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> CC: Luiz Capitulino <lcapitulino@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp-commands.hx | 2 +-
>  qemu-options.hx | 5 ++++-
>  qmp-commands.hx | 2 +-
>  3 files changed, 6 insertions(+), 3 deletions(-)
...
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 0d52d02..eeaf2a1 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1575,7 +1575,10 @@ DEF("net", HAS_ARG, QEMU_OPTION_net,
>      "socket][,vlan=n][,option][,option][,...]\n"
>      "                old way to initialize a host network interface\n"
>      "                (use the -netdev option if possible instead)\n", QEMU_ARCH_ALL)
> -DEF("netfilter", HAS_ARG, QEMU_OPTION_netfilter, "", QEMU_ARCH_ALL)
> +DEF("netfilter", HAS_ARG, QEMU_OPTION_netfilter,
> +    "-netfilter buffer,id=str,netdev=str[,chain=in|out|all,interval=n]\n"
> +    "                buffer netdev in/out packets. if interval provided, will release\n"
> +    "                packets by interval. interval scale: microsecond\n", QEMU_ARCH_ALL)
>  STEXI
>  @item -net nic[,vlan=@var{n}][,macaddr=@var{mac}][,model=@var{type}] [,name=@var{name}][,addr=@var{addr}][,vectors=@var{v}]
>  @findex -net

Could you maybe also add some more explicit description for the filter
to the TEXI section (i.e. between the above STEXI and the ETEXI later in
this file)? That could be really helpful for the users when they look
for information about this option in the User's Documentation (see
http://qemu.weilnetz.de/qemu-doc.html for a generated version for example)

 Thomas