From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
Cc: chen.fan.fnst@cn.fujitsu.com, imammedo@redhat.com,
izumi.taku@jp.fujitsu.com, qemu-devel@nongnu.org,
afaerber@suse.de
Subject: Re: [Qemu-devel] [RESEND PATCH v9 1/4] apic: map APIC's MMIO region at each CPU's address space
Date: Sun, 23 Aug 2015 17:55:23 -0700 [thread overview]
Message-ID: <55DA6B7B.2090408@redhat.com> (raw)
In-Reply-To: <20150821225459.GB5816@thinpad.lan.raisama.net>
On 21/08/2015 15:54, Eduardo Habkost wrote:
> > + if (tcg_enabled()) {
> > + memory_region_add_subregion_overlap(cpu->cpu_as_root,
> > + apic->apicbase &
> > + MSR_IA32_APICBASE_BASE,
> > + &apic->io_memory,
> > + 0x1000);
>
> Why exactly is this necessary? If this is necessary, why don't we need
> to do this for non-TCG accelerators?
At least KVM and qtest do not support per-CPU address spaces. I'm not
sure about Xen, it looks like it could but it would be slower.
Paolo
next prev parent reply other threads:[~2015-08-24 0:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 9:36 [Qemu-devel] [RESEND PATCH v9 0/4] remove icc bus/bridge Zhu Guihua
2015-08-19 9:36 ` [Qemu-devel] [RESEND PATCH v9 1/4] apic: map APIC's MMIO region at each CPU's address space Zhu Guihua
2015-08-21 22:54 ` Eduardo Habkost
2015-08-24 0:55 ` Paolo Bonzini [this message]
2015-08-24 14:56 ` Peter Maydell
2015-08-26 14:59 ` Eduardo Habkost
2015-08-26 15:27 ` Paolo Bonzini
2015-08-26 15:49 ` Eduardo Habkost
2015-08-27 8:18 ` Zhu Guihua
2015-08-19 9:36 ` [Qemu-devel] [RESEND PATCH v9 2/4] x86: use new method to correct reset sequence Zhu Guihua
2015-08-21 22:57 ` Eduardo Habkost
2015-08-19 9:36 ` [Qemu-devel] [RESEND PATCH v9 3/4] cpu/apic: drop icc bus/bridge Zhu Guihua
2015-08-19 9:36 ` [Qemu-devel] [RESEND PATCH v9 4/4] icc_bus: drop the unused files Zhu Guihua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DA6B7B.2090408@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).