From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTh5R-0000Tj-0p for qemu-devel@nongnu.org; Sun, 23 Aug 2015 22:02:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTh5Q-0003Z9-9n for qemu-devel@nongnu.org; Sun, 23 Aug 2015 22:02:12 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:35727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTh5Q-0003Yw-3J for qemu-devel@nongnu.org; Sun, 23 Aug 2015 22:02:12 -0400 Received: by wicne3 with SMTP id ne3so58631130wic.0 for ; Sun, 23 Aug 2015 19:02:11 -0700 (PDT) Sender: Paolo Bonzini References: <1440375847-17603-1-git-send-email-cota@braap.org> <1440375847-17603-26-git-send-email-cota@braap.org> From: Paolo Bonzini Message-ID: <55DA7AF0.5080303@redhat.com> Date: Sun, 23 Aug 2015 19:01:20 -0700 MIME-Version: 1.0 In-Reply-To: <1440375847-17603-26-git-send-email-cota@braap.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC 25/38] cpu: add barriers around cpu->tcg_exit_req List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org, mttcg@greensocs.com Cc: guillaume.delbergue@greensocs.com, alex.bennee@linaro.org, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, Frederic Konrad On 23/08/2015 17:23, Emilio G. Cota wrote: > @@ -16,6 +16,7 @@ static inline void gen_tb_start(TranslationBlock *tb) > > exitreq_label = gen_new_label(); > flag = tcg_temp_new_i32(); > + tcg_gen_smp_rmb(); > tcg_gen_ld_i32(flag, cpu_env, > offsetof(CPUState, tcg_exit_req) - ENV_OFFSET); > tcg_gen_brcondi_i32(TCG_COND_NE, flag, 0, exitreq_label); This can also be done in cpu-exec.c. I have addressed Richard Henderson's comments on the "signal-free TCG exit" patches and will resend them asap. Paolo