From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTweM-0006Lq-Lt for qemu-devel@nongnu.org; Mon, 24 Aug 2015 14:39:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTweL-00088O-S4 for qemu-devel@nongnu.org; Mon, 24 Aug 2015 14:39:18 -0400 References: <1440403565-27432-1-git-send-email-pl@kamp.de> From: Max Reitz Message-ID: <55DB64CC.2040207@redhat.com> Date: Mon, 24 Aug 2015 20:39:08 +0200 MIME-Version: 1.0 In-Reply-To: <1440403565-27432-1-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com On 24.08.2015 10:06, Peter Lieven wrote: > If the file is readonly its not expected to grow so > save the blocking call to nfs_fstat_async and use > the value saved at connection time. Also important > the monitor (and thus the main loop) will not hang > if block device info is queried and the NFS share > is unresponsive. > > Signed-off-by: Peter Lieven > --- > v1->v2: update cache on reopen_prepare [Max] > > block/nfs.c | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) Reviewed-by: Max Reitz I hope you're ready for the "Stale actual-size value with cache=direct,read-only=on,format=raw files on NFS" reports. :-)