From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50067)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1ZTxVm-0006Hg-KB
	for qemu-devel@nongnu.org; Mon, 24 Aug 2015 15:34:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1ZTxVj-0001QT-Cu
	for qemu-devel@nongnu.org; Mon, 24 Aug 2015 15:34:30 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:38077 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1ZTxVj-0001MQ-1t
	for qemu-devel@nongnu.org; Mon, 24 Aug 2015 15:34:27 -0400
Message-ID: <55DB71BD.3080402@kamp.de>
Date: Mon, 24 Aug 2015 21:34:21 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1440403565-27432-1-git-send-email-pl@kamp.de>
	<55DB64CC.2040207@redhat.com>
In-Reply-To: <55DB64CC.2040207@redhat.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for
	read-only files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com

Am 24.08.2015 um 20:39 schrieb Max Reitz:
> On 24.08.2015 10:06, Peter Lieven wrote:
>> If the file is readonly its not expected to grow so
>> save the blocking call to nfs_fstat_async and use
>> the value saved at connection time. Also important
>> the monitor (and thus the main loop) will not hang
>> if block device info is queried and the NFS share
>> is unresponsive.
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>> v1->v2: update cache on reopen_prepare [Max]
>>
>>  block/nfs.c | 35 +++++++++++++++++++++++++++++++++++
>>  1 file changed, 35 insertions(+)
> Reviewed-by: Max Reitz <mreitz@redhat.com>
>
> I hope you're ready for the "Stale actual-size value with
> cache=direct,read-only=on,format=raw files on NFS" reports. :-)
actually a good point, maybe the cache should only be used if

!(bs->open_flags & BDRV_O_NOCACHE)

for my cdrom stuff this is still ok.

Peter