From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTy7S-0003Kb-8g for qemu-devel@nongnu.org; Mon, 24 Aug 2015 16:13:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTy7R-0005sH-FF for qemu-devel@nongnu.org; Mon, 24 Aug 2015 16:13:26 -0400 References: <1440403565-27432-1-git-send-email-pl@kamp.de> <55DB64CC.2040207@redhat.com> <55DB71BD.3080402@kamp.de> From: Max Reitz Message-ID: <55DB7ADC.1010109@redhat.com> Date: Mon, 24 Aug 2015 22:13:16 +0200 MIME-Version: 1.0 In-Reply-To: <55DB71BD.3080402@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RB6Ohr9wKqDEb9kar8HwA9oq9AumXt0N9" Subject: Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RB6Ohr9wKqDEb9kar8HwA9oq9AumXt0N9 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 24.08.2015 21:34, Peter Lieven wrote: > Am 24.08.2015 um 20:39 schrieb Max Reitz: >> On 24.08.2015 10:06, Peter Lieven wrote: >>> If the file is readonly its not expected to grow so >>> save the blocking call to nfs_fstat_async and use >>> the value saved at connection time. Also important >>> the monitor (and thus the main loop) will not hang >>> if block device info is queried and the NFS share >>> is unresponsive. >>> >>> Signed-off-by: Peter Lieven >>> --- >>> v1->v2: update cache on reopen_prepare [Max] >>> >>> block/nfs.c | 35 +++++++++++++++++++++++++++++++++++ >>> 1 file changed, 35 insertions(+) >> Reviewed-by: Max Reitz >> >> I hope you're ready for the "Stale actual-size value with >> cache=3Ddirect,read-only=3Don,format=3Draw files on NFS" reports. :-) > actually a good point, maybe the cache should only be used if >=20 > !(bs->open_flags & BDRV_O_NOCACHE) Good enough a point to fix it? ;-) Max --RB6Ohr9wKqDEb9kar8HwA9oq9AumXt0N9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV23rcAAoJEDuxQgLoOKytenEIAIEFLRCq0r0UQr3gii9nN0DX mOO8yarZVx+1FEtl+arsrdkfeRa1gGgiIQVtvcwGkxT6tDMmCb7Sl9fdsMxXkl2a 4BPC68zUjsGxjwOFZ/MFU9GFn7sE6IrFZxx+rIGT4p9dDZcXTcDScZOpb3/H/kir xyPA1BYeKfRgCSnFFe4sEgLznw/mHLZvn2NAhsYCIau9MAs6iHHCoDVfZEaOOTPT 9rriS3TAaApzTeeGmjaH/0sXxAgBOMKeVLiYiVBQ4euKj5vshp82vcNuBS9PuQY+ ruzPr/Y2NMV6WlN5hWAnSTdtDPMMeofUWEhsNcSuCLY4SfBPe2yg7Ts/FlFLeFw= =BVta -----END PGP SIGNATURE----- --RB6Ohr9wKqDEb9kar8HwA9oq9AumXt0N9--