From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTyG3-0001n1-8b for qemu-devel@nongnu.org; Mon, 24 Aug 2015 16:22:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTyFz-0003GM-U3 for qemu-devel@nongnu.org; Mon, 24 Aug 2015 16:22:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:39740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTyFz-0003Fh-OM for qemu-devel@nongnu.org; Mon, 24 Aug 2015 16:22:15 -0400 References: <1440407824-30037-1-git-send-email-pl@kamp.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <55DB7CF7.3030300@suse.de> Date: Mon, 24 Aug 2015 14:22:15 -0600 MIME-Version: 1.0 In-Reply-To: <1440407824-30037-1-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, ehabkost@redhat.com, rth@twiddle.net Hi, Am 24.08.2015 um 03:17 schrieb Peter Lieven: > this patch adds a probe that lists all enforceable and migrateable > CPU models to the -cpu help output. The idea is to know a priory > which CPU modules can be exposed to the user without loosing any models > feature flags. >=20 > Signed-off-by: Peter Lieven > --- > target-i386/cpu.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++= ++ > 1 file changed, 49 insertions(+) >=20 > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index cfb8aa7..3a56d3f 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c [...] > @@ -1987,6 +2026,16 @@ void x86_cpu_list(FILE *f, fprintf_function cpu_= fprintf) > listflags(f, cpu_fprintf, fw->feat_names); > (*cpu_fprintf)(f, "\n"); > } > + > + (*cpu_fprintf)(f, "\nEnforceable and migratable x86 CPU models in = KVM mode:\n"); > + (*cpu_fprintf)(f, " "); > + for (i =3D 0; i < ARRAY_SIZE(builtin_x86_defs); i++) { > + def =3D &builtin_x86_defs[i]; > + if (x86_cpu_enforce_and_migratable(def)) { > + (*cpu_fprintf)(f, " %s", def->name); > + } > + } > + (*cpu_fprintf)(f, "\n"); > } > =20 > CpuDefinitionInfoList *arch_query_cpu_definitions(Error **errp) I don't think adding a new section is such a good idea here, it may add more confusion than it helps. I would rather suggest to add some annotation to the existing list. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)