From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47329)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZU4gg-00069I-VU
	for qemu-devel@nongnu.org; Mon, 24 Aug 2015 23:14:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZU4gc-0002k9-0y
	for qemu-devel@nongnu.org; Mon, 24 Aug 2015 23:14:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40905)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZU4gb-0002jJ-Ro
	for qemu-devel@nongnu.org; Mon, 24 Aug 2015 23:14:09 -0400
Message-ID: <55DBDD7D.3010000@redhat.com>
Date: Tue, 25 Aug 2015 11:14:05 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <1440147950-1178-1-git-send-email-jasowang@redhat.com>	<1440147950-1178-4-git-send-email-jasowang@redhat.com>	<20150821114359.7008df9c.cornelia.huck@de.ibm.com>	<55DAAD82.5060407@redhat.com>
	<20150824161406.0f49d252.cornelia.huck@de.ibm.com>
In-Reply-To: <20150824161406.0f49d252.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/6] virtio-pci: fix 1.0 virtqueue migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com



On 08/24/2015 10:14 PM, Cornelia Huck wrote:
> On Mon, 24 Aug 2015 13:37:06 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
>> On 08/21/2015 05:43 PM, Cornelia Huck wrote:
>>> On Fri, 21 Aug 2015 17:05:47 +0800
>>> Jason Wang <jasowang@redhat.com> wrote:
>>>> +        k->has_modern_state &&
>>>> +        k->has_modern_state(qbus->parent);
>>>> +}
>>> I don't really like this "modern_state" stuff (which is pci specific)
>>> creeping into core.
>>>
>>> How about introducing "extra_state" and/or "extra_queue_state" (or
>>> something like that) instead?
>>>
>> Ok, if you don't like pci specific name, maybe something like
>> "virtio_1_state" is better?
> I was thinking more along the lines of "transport wants to save/restore
> additional state for the device" - which is not neccessarily depending
> on virtio-1. It would be good if a transport can extend the state
> without needlessly introducing incompatibilities.

I see.

>
> pci can handle its modern state via this then and encapsulate it.
>

Ok. Will have a try.