From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU9xA-0002f2-9l for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:51:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZU9x9-0002Fh-9Q for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:51:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU9x9-0002Fb-3X for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:51:35 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id C1A49461D9 for ; Tue, 25 Aug 2015 08:51:34 +0000 (UTC) References: <1439939502-4722-1-git-send-email-ehabkost@redhat.com> <20150819095526.GB2332@work-vm> <55D4C813.1070308@redhat.com> <87vbc5qadz.fsf@blackfin.pond.sub.org> From: Marcel Apfelbaum Message-ID: <55DC2C93.50407@redhat.com> Date: Tue, 25 Aug 2015 11:51:31 +0300 MIME-Version: 1.0 In-Reply-To: <87vbc5qadz.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] q35: Remove old machine versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , John Snow Cc: Eduardo Habkost , Marcel Apfelbaum , "Michael S. Tsirkin" , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Paolo Bonzini , Laszlo Ersek On 08/24/2015 12:54 PM, Markus Armbruster wrote: > John Snow writes: > >> On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote: >>> * Eduardo Habkost (ehabkost@redhat.com) wrote: >>>> Migration with q35 was not possible before commit >>>> 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates >>>> an ich9-ahci device, that was marked as unmigratable. So all q35 machines >>>> before pc-q35-2.4 were unmigratable, and there's no point in keeping >>>> compatibility code for them. >>>> >>>> Remove all old pc-q35 machine classes and keep only pc-q35-2.4. >>> >>> But doesn't that mean that anyone who has a machine configured with one >>> of those machine types will suddenly find it wont start? >>> >>> Dave >>> >> >> To some extent, all versions of this board prior to 2.4 should be >> considered unsupported and we should discourage their use anyway. >> >> If you really want, I suppose we could just alias them to 2.4 ... > > I'd very much prefer an honest "won't start" over a silent change of the > machine type. +1 Thanks, Marcel > > If we really want to bend over backwards for existing uses of these > machine types, we could make them error out with "use pc-q35-2.5 > instead". Since I don't think they exist outside testing, I wouldn't > bother. >