From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40617)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZU9yr-0003l7-E3
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:53:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZU9yo-0002tx-5o
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:53:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42949)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZU9yo-0002tp-0c
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:53:18 -0400
References: <1440107676-17326-1-git-send-email-ehabkost@redhat.com>
	<1440107676-17326-2-git-send-email-ehabkost@redhat.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <55DC2CFB.7070003@redhat.com>
Date: Tue, 25 Aug 2015 11:53:15 +0300
MIME-Version: 1.0
In-Reply-To: <1440107676-17326-2-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/10] machine: MACHINE_TYPE_NAME macro
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Cc: Marcel Apfelbaum <marcel.a@redhat.com>, David Gibson <david@gibson.dropbear.id.au>

On 08/21/2015 12:54 AM, Eduardo Habkost wrote:
> The macro will be useful to ensure the machine class names follow the
> right format to make machine class lookup by class name work correctly.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   include/hw/boards.h | 6 ++++++
>   vl.c                | 2 +-
>   2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 3f84afd..178517c 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -40,6 +40,12 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
>   int qemu_register_machine(QEMUMachine *m);
>
>   #define TYPE_MACHINE_SUFFIX "-machine"
> +
> +/* Machine class name that needs to be used for class-name-based machine
> + * type lookup to work.
> + */
> +#define MACHINE_TYPE_NAME(machinename) (machinename TYPE_MACHINE_SUFFIX)
> +
>   #define TYPE_MACHINE "machine"
>   #undef MACHINE  /* BSD defines it and QEMU does not use it */
>   #define MACHINE(obj) \
> diff --git a/vl.c b/vl.c
> index 584ca88..b7ddfeb 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1447,7 +1447,7 @@ static void qemu_machine_class_init(ObjectClass *oc, void *data)
>
>   int qemu_register_machine(QEMUMachine *m)
>   {
> -    char *name = g_strconcat(m->name, TYPE_MACHINE_SUFFIX, NULL);
> +    char *name = g_strdup_printf(MACHINE_TYPE_NAME("%s"), m->name);
>       TypeInfo ti = {
>           .name       = name,
>           .parent     = TYPE_MACHINE,
>

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel