From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZU9zB-00044A-1C
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:53:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZU9zA-0002z2-6S
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:53:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46949)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZU9zA-0002yx-0E
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 04:53:40 -0400
References: <1440107676-17326-1-git-send-email-ehabkost@redhat.com>
	<1440107676-17326-10-git-send-email-ehabkost@redhat.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <55DC2D11.7000705@redhat.com>
Date: Tue, 25 Aug 2015 11:53:37 +0300
MIME-Version: 1.0
In-Reply-To: <1440107676-17326-10-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/10] machine: Ensure all TYPE_MACHINE
 subclasses have the right suffix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Cc: Marcel Apfelbaum <marcel.a@redhat.com>, David Gibson <david@gibson.dropbear.id.au>

On 08/21/2015 12:54 AM, Eduardo Habkost wrote:
> Now that all non-abstract TYPE_MACHINE subclasses have the -machine
> suffix, add an assert to ensure this will be always true.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   hw/core/machine.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index ac4654e..e50c4b7 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -302,6 +302,14 @@ static void machine_class_init(ObjectClass *oc, void *data)
>       mc->default_ram_size = 128 * M_BYTE;
>   }
>
> +static void machine_class_base_init(ObjectClass *oc, void *data)
> +{
> +    if (!object_class_is_abstract(oc)) {
> +        const char *cname = object_class_get_name(oc);
> +        assert(g_str_has_suffix(cname, TYPE_MACHINE_SUFFIX));
> +    }
> +}
> +
>   static void machine_initfn(Object *obj)
>   {
>       MachineState *ms = MACHINE(obj);
> @@ -472,6 +480,7 @@ static const TypeInfo machine_info = {
>       .abstract = true,
>       .class_size = sizeof(MachineClass),
>       .class_init    = machine_class_init,
> +    .class_base_init = machine_class_base_init,
>       .instance_size = sizeof(MachineState),
>       .instance_init = machine_initfn,
>       .instance_finalize = machine_finalize,
>

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel