Re: [Qemu-devel] [PATCH v2 for 2.5 0/3] Move target- and device specific code from monitor

["Denis V. Lunev" <den@openvz.org>]

On 08/12/2015 02:50 PM, Denis V. Lunev wrote:
> The monivation of this set is simple. Recently we have proposed patch
> to monitor.c with specific x86 APIC HMP commands. The patchset was denied
> with the main motivation "No more arch specific code in monitor.c"
> This patchset is the first step to move arch specific code from
> monitor.c targets.
>
> So, monitor.c already contains a lot of generic code, as well as the target
> specifics code and eventually monitor.c volume will only grow. This trend leads
> to a variety of fouling code ifdeffery(and combinations thereof),
> poor readability, and entanglement of architecture of the project.
> If someone wants to improve processing logic commands at the monitor,
> it isn't necessarily must differentiate amongst the implementation of some ARM
> or x86_64 specific commands, because the project already has separation of
> target specific code on directories.
>
> The presented solution is not the best, but it is quite simple
> (PATCH doesn't add more code!) and decides the above mentioned issue.
> Subsequently it will not prevent the introduction of more advanced mechanism
> that can more effectively resolve the issue.
>
> There is a issue with the placement of code for multiple architectures
> (isn't for everyone), but this code is very small. This patch is a step towards
> solving the issue associated with maintaining the purity of the code and
> structure of the project, which solves not all, but doing a little better
> than it is.
>
> Changes from v1:
> - ported to new head
>
> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Luiz Capitulino <lcapitulino@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Peter Maydell <peter.maydell@linaro.org>
>
ping v2