From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZUEhd-0005q4-QO
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 09:55:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZUEhY-0005XF-RB
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 09:55:53 -0400
Message-ID: <55DC73DE.4050506@redhat.com>
Date: Tue, 25 Aug 2015 15:55:42 +0200
From: Thomas Huth <thuth@redhat.com>
MIME-Version: 1.0
References: <1440417809-21069-1-git-send-email-gwshan@linux.vnet.ibm.com>
	<1440417809-21069-7-git-send-email-gwshan@linux.vnet.ibm.com>
In-Reply-To: <1440417809-21069-7-git-send-email-gwshan@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 6/8] sPAPR: Introduce rtas_ldq()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: aik@ozlabs.ru, peter.maydell@linaro.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au

On 24/08/15 14:03, Gavin Shan wrote:
> This introduces rtas_ldq() to load 64-bits parameter from continuous
> two 4-bytes memory chunk of RTAS parameter buffer, to simplify the
> code.
> 
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> ---
>  hw/ppc/spapr_pci.c     | 20 ++++++++++----------
>  include/hw/ppc/spapr.h |  5 +++++
>  2 files changed, 15 insertions(+), 10 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>