From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUGtO-0007H9-Hm for qemu-devel@nongnu.org; Tue, 25 Aug 2015 12:16:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUGtL-0006Mt-8p for qemu-devel@nongnu.org; Tue, 25 Aug 2015 12:16:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUGtK-0006Lz-Lx for qemu-devel@nongnu.org; Tue, 25 Aug 2015 12:16:06 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 1DD6155 for ; Tue, 25 Aug 2015 16:16:06 +0000 (UTC) References: <1439939502-4722-1-git-send-email-ehabkost@redhat.com> <20150819095526.GB2332@work-vm> <20150819163020.GC32203@thinpad.lan.raisama.net> <20150825124140-mutt-send-email-mst@redhat.com> From: John Snow Message-ID: <55DC94C4.6000205@redhat.com> Date: Tue, 25 Aug 2015 12:16:04 -0400 MIME-Version: 1.0 In-Reply-To: <20150825124140-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] q35: Remove old machine versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Eduardo Habkost Cc: Marcel Apfelbaum , qemu-devel@nongnu.org, Markus Armbruster , "Dr. David Alan Gilbert" , Paolo Bonzini , Laszlo Ersek On 08/25/2015 05:42 AM, Michael S. Tsirkin wrote: > On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote: >> On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote: >>> * Eduardo Habkost (ehabkost@redhat.com) wrote: >>>> Migration with q35 was not possible before commit >>>> 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates >>>> an ich9-ahci device, that was marked as unmigratable. So all q35 machines >>>> before pc-q35-2.4 were unmigratable, and there's no point in keeping >>>> compatibility code for them. >>>> >>>> Remove all old pc-q35 machine classes and keep only pc-q35-2.4. >>> >>> But doesn't that mean that anyone who has a machine configured with one >>> of those machine types will suddenly find it wont start? >> >> Yes, and they will have to update their configuration to use pc-q35-2.4 >> or newer. > > That seems easily avoidable: just make pc-q35-X alias pc-q35-2.4 for X < 2.4. > Both Marcel and Markus would prefer it to fail outright instead of silently perform magic, in response to my suggesting the same thing. >> -- >> Eduardo