From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1ZUPxi-0000XP-0N
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 21:57:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1ZUPxh-0000Nv-6X
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 21:57:13 -0400
Message-ID: <55DD1CD5.5070008@huawei.com>
Date: Wed, 26 Aug 2015 09:56:37 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1440553971-11108-1-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1440553971-11108-1-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware
	path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, peter.huangpeng@huawei.com, "qemu-stable@nongnu.org" <qemu-stable@nongnu.org>

On 2015/8/26 9:52, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> vhost-scsi bootindex does't work because Qemu passes
> wrong fireware path to seabios.
> 
> before:
>   /pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0
> after applying the patch:
>   /pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0
> 
> Reported-by: Subo <subo7@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/scsi/vhost-scsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Cc: qemu-stable@nongnu.org

> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index 7eacca9..bac9ddb 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -292,7 +292,7 @@ static char *vhost_scsi_get_fw_dev_path(FWPathProvider *p, BusState *bus,
>  {
>      VHostSCSI *s = VHOST_SCSI(dev);
>      /* format: channel@channel/vhost-scsi@target,lun */
> -    return g_strdup_printf("channel@%x/%s@%x,%x", s->channel,
> +    return g_strdup_printf("/channel@%x/%s@%x,%x", s->channel,
>                             qdev_fw_name(dev), s->target, s->lun);
>  }
>  
>