From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUWr3-0008Vy-G4 for qemu-devel@nongnu.org; Wed, 26 Aug 2015 05:18:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUWqz-0000O3-KI for qemu-devel@nongnu.org; Wed, 26 Aug 2015 05:18:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:45236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUWqz-0000Nr-EV for qemu-devel@nongnu.org; Wed, 26 Aug 2015 05:18:45 -0400 References: <1439897731-3645-1-git-send-email-phil@philkern.de> <1439898655-6275-1-git-send-email-phil@philkern.de> <55D60B51.1000201@tuxfamily.org> From: Alexander Graf Message-ID: <55DD8472.4050600@suse.de> Date: Wed, 26 Aug 2015 11:18:42 +0200 MIME-Version: 1.0 In-Reply-To: <55D60B51.1000201@tuxfamily.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-s390x: Mask the SIGP order_code to 8bit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Philipp Kern , qemu-devel@nongnu.org, Richard Henderson On 20.08.15 19:16, Thomas Huth wrote: > On 18/08/15 04:50, Philipp Kern wrote: >> According to "CPU Signaling and Response", "Signal-Processor Orders", >> the order field is bit position 56-63. Without this, the Linux >> guest kernel is sometimes unable to stop emulation and enters >> an infinite loop of "XXX unknown sigp: 0xffffffff00000005". >> >> Signed-off-by: Philipp Kern >> --- >> target-s390x/misc_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c >> index 8eac0e1..0f0907c 100644 >> --- a/target-s390x/misc_helper.c >> +++ b/target-s390x/misc_helper.c >> @@ -500,7 +500,7 @@ uint32_t HELPER(sigp)(CPUS390XState *env, uint64_t order_code, uint32_t r1, >> /* Remember: Use "R1 or R1 + 1, whichever is the odd-numbered register" >> as parameter (input). Status (output) is always R1. */ >> >> - switch (order_code) { >> + switch (order_code & 0xff) { >> case SIGP_SET_ARCH: >> /* switch arch */ >> break; > > Reviewed-by: Thomas Huth Thanks, applied to s390-next. Alex