From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54874)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZUXHR-000192-0c
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 05:46:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZUXHN-0005Zs-SD
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 05:46:04 -0400
Received: from mga11.intel.com ([192.55.52.93]:13847)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZUXHN-0005ZN-Lx
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 05:46:01 -0400
References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1439563931-12352-8-git-send-email-guangrong.xiao@linux.intel.com>
	<20150825151247.GB8344@stefanha-thinkpad.redhat.com>
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Message-ID: <55DD897C.4030904@linux.intel.com>
Date: Wed, 26 Aug 2015 17:40:12 +0800
MIME-Version: 1.0
In-Reply-To: <20150825151247.GB8344@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for
 NVDIMM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, imammedo@redhat.com, rth@twiddle.net



On 08/25/2015 11:12 PM, Stefan Hajnoczi wrote:
> On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote:
>> diff --git a/hw/mem/nvdimm/pc-nvdimm.c b/hw/mem/nvdimm/pc-nvdimm.c
>> index a53d235..7a270a8 100644
>> --- a/hw/mem/nvdimm/pc-nvdimm.c
>> +++ b/hw/mem/nvdimm/pc-nvdimm.c
>> @@ -24,6 +24,19 @@
>>
>>   #include "hw/mem/pc-nvdimm.h"
>>
>> +#define PAGE_SIZE      (1UL << 12)
>
> This macro name is likely to collide with system headers or other code.
>
> Could you use the existing TARGET_PAGE_SIZE constant instead?
>

Will follow your way in the next version. Thank you for pointing it out.