From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUYMZ-0003JW-Pz for qemu-devel@nongnu.org; Wed, 26 Aug 2015 06:55:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUYMW-0005Xt-LH for qemu-devel@nongnu.org; Wed, 26 Aug 2015 06:55:27 -0400 Received: from mga02.intel.com ([134.134.136.20]:34060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUYMW-0005Xg-Fc for qemu-devel@nongnu.org; Wed, 26 Aug 2015 06:55:24 -0400 References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com> <20150825162649.GI8344@stefanha-thinkpad.redhat.com> From: Xiao Guangrong Message-ID: <55DD99BF.4070608@linux.intel.com> Date: Wed, 26 Aug 2015 18:49:35 +0800 MIME-Version: 1.0 In-Reply-To: <20150825162649.GI8344@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, rth@twiddle.net On 08/26/2015 12:26 AM, Stefan Hajnoczi wrote: > On Fri, Aug 14, 2015 at 10:51:53PM +0800, Xiao Guangrong wrote: >> Changlog: >> - Use litten endian for DSM method, thanks for Stefan's suggestion >> >> - introduce a new parameter, @configdata, if it's false, Qemu will >> build a static and readonly namespace in memory and use it serveing >> for DSM GET_CONFIG_SIZE/GET_CONFIG_DATA requests. In this case, no >> reserved region is needed at the end of the @file, it is good for >> the user who want to pass whole nvdimm device and make its data >> completely be visible to guest >> >> - divide the source code into separated files and add maintain info > > I have skipped ACPI patches because I'm not very familiar with that > area. Thank you very much for your review, your comment is great helpful to me, Stefan! > > Have you thought about live migration? > > Are the contents of the NVDIMM migrated since they are registered as a > RAM region? Will fully test live migration and VM save before sending the V3 out. :)