From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUdLj-0000D8-FO for qemu-devel@nongnu.org; Wed, 26 Aug 2015 12:14:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUdLg-00038d-4A for qemu-devel@nongnu.org; Wed, 26 Aug 2015 12:14:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUdLf-00038H-UU for qemu-devel@nongnu.org; Wed, 26 Aug 2015 12:14:52 -0400 References: <1440107676-17326-1-git-send-email-ehabkost@redhat.com> <1440107676-17326-11-git-send-email-ehabkost@redhat.com> <55DC2C43.10706@redhat.com> <20150826150221.GB4230@thinpad.lan.raisama.net> From: Marcel Apfelbaum Message-ID: <55DDE5BF.7070707@redhat.com> Date: Wed, 26 Aug 2015 19:13:51 +0300 MIME-Version: 1.0 In-Reply-To: <20150826150221.GB4230@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/10] machine: Set MachineClass::name automatically List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Marcel Apfelbaum , David Gibson , qemu-devel@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= On 08/26/2015 06:02 PM, Eduardo Habkost wrote: > On Tue, Aug 25, 2015 at 11:50:11AM +0300, Marcel Apfelbaum wrote: >> On 08/21/2015 12:54 AM, Eduardo Habkost wrote: >>> Now all TYPE_MACHINE subclasses use MACHINE_TYPE_NAME to generate the >>> class name. So instead of requiring each subclass to set >>> MachineClass::name manually, we can now set it automatically at the >>> TYPE_MACHINE class_base_init() function. >>> >>> Signed-off-by: Eduardo Habkost >>> --- >>> hw/arm/vexpress.c | 2 -- >>> hw/arm/virt.c | 1 - >>> hw/core/machine.c | 3 +++ >>> hw/ppc/mac_newworld.c | 1 - >>> hw/ppc/spapr.c | 4 ---- >>> hw/s390x/s390-virtio.c | 1 - >>> vl.c | 1 - >>> 7 files changed, 3 insertions(+), 10 deletions(-) > [...] >>> diff --git a/vl.c b/vl.c >>> index b7ddfeb..870ee48 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -1432,7 +1432,6 @@ static void qemu_machine_class_init(ObjectClass *oc, void *data) >>> { >>> MachineClass *mc = MACHINE_CLASS(oc); >>> QEMUMachine *qm = data; >>> - mc->name = qm->name; >>> mc->desc = qm->desc; >>> mc->init = qm->init; >>> mc->kvm_type = qm->kvm_type; >>> >> >> Nice! >> >> Please forget the possible stupid question, but what happens with >> *all* other machine types? Why don't we have to remove the "name" >> assignment from the other machine types too? > > Unless I made a mistake and missed something when grepping the code, all > machine-types were changed. Most of them use qemu_register_machine() > (which uses qemu_machine_class_init(), changed above). > OK, thanks for the answer. Reviewed-by: Marcel Apfelbaum Thanks, Marcel