From: "Kővágó Zoltán" <dirty.ice.hu@gmail.com>
To: Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print
Date: Thu, 27 Aug 2015 00:31:52 +0200 [thread overview]
Message-ID: <55DE3E58.4070906@gmail.com> (raw)
In-Reply-To: <878u8ynqbx.fsf@blackfin.pond.sub.org>
2015-08-26 15:15 keltezéssel, Markus Armbruster írta:
> Stefan Hajnoczi <stefanha@gmail.com> writes:
>
>> On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán <dirty.ice.hu@gmail.com> wrote:
>>> This will let us print options in a format that the user would actually
>>> write it on the command line (foo=bar,baz=asd,etc=def), without
>>> prepending a spurious comma at the beginning of the list, or quoting
>>> values unnecessarily. This patch provides the following changes:
>>> * write and id=, if the option has an id
>>> * do not print separator before the first element
>>> * do not quote string arguments
>>> * properly escape commas (,) for QEMU
>>>
>>> Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
>>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>
>> Feel free to send a "Ping" email reply if your patches haven't been
>> reviewed after about 1 week.
>>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Route via qemu-trivial or qemu-block?
>
Hmm, I originally intended qemu-trivial, qemu-block was added via
scripts/get_maintainer.pl.
Zoltan
next prev parent reply other threads:[~2015-08-26 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 14:42 [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print Kővágó, Zoltán
2015-07-28 12:30 ` Stefan Hajnoczi
2015-08-26 13:15 ` Markus Armbruster
2015-08-26 22:31 ` Kővágó Zoltán [this message]
2015-08-28 10:04 ` Markus Armbruster
2015-08-20 14:57 ` Marc-André Lureau
2015-09-06 11:01 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DE3E58.4070906@gmail.com \
--to=dirty.ice.hu@gmail.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).