From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUjEg-0004AI-I0 for qemu-devel@nongnu.org; Wed, 26 Aug 2015 18:32:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUjEf-0008UV-Lk for qemu-devel@nongnu.org; Wed, 26 Aug 2015 18:32:02 -0400 From: "=?UTF-8?B?S8WRdsOhZ8OzIFpvbHTDoW4=?=" References: <878u8ynqbx.fsf@blackfin.pond.sub.org> Message-ID: <55DE3E58.4070906@gmail.com> Date: Thu, 27 Aug 2015 00:31:52 +0200 MIME-Version: 1.0 In-Reply-To: <878u8ynqbx.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Stefan Hajnoczi Cc: qemu-trivial , Kevin Wolf , qemu-devel , "open list:Block layer core" 2015-08-26 15:15 keltezéssel, Markus Armbruster írta: > Stefan Hajnoczi writes: > >> On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán wrote: >>> This will let us print options in a format that the user would actually >>> write it on the command line (foo=bar,baz=asd,etc=def), without >>> prepending a spurious comma at the beginning of the list, or quoting >>> values unnecessarily. This patch provides the following changes: >>> * write and id=, if the option has an id >>> * do not print separator before the first element >>> * do not quote string arguments >>> * properly escape commas (,) for QEMU >>> >>> Signed-off-by: Kővágó, Zoltán >>> Reviewed-by: Markus Armbruster >> >> Feel free to send a "Ping" email reply if your patches haven't been >> reviewed after about 1 week. >> >> Reviewed-by: Stefan Hajnoczi > > Route via qemu-trivial or qemu-block? > Hmm, I originally intended qemu-trivial, qemu-block was added via scripts/get_maintainer.pl. Zoltan