From: Laszlo Ersek <lersek@redhat.com>
To: Wei Huang <wei@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, drjones@redhat.com,
ard.biesheuvel@linaro.org, ehabkost@redhat.com,
ivan.khoronzhuk@linaro.org, mst@redhat.com, somlo@cmu.edu,
zhaoshenglong@huawei.com, leif.lindholm@linaro.org,
roy.franz@linaro.org, pbonzini@redhat.com, imammedo@redhat.com,
jdelvare@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [ARM SMBIOS V5 PATCH 1/2] smbios: add smbios 3.0 support
Date: Thu, 27 Aug 2015 08:15:22 +0200 [thread overview]
Message-ID: <55DEAAFA.4050709@redhat.com> (raw)
In-Reply-To: <1440615870-9518-2-git-send-email-wei@redhat.com>
On 08/26/15 21:04, Wei Huang wrote:
> This patch adds support for SMBIOS 3.0 entry point. When caller invokes
> smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then
> smbios_get_tables() will return the entry point table in right format.
>
> Acked-by: Gabriel Somlo <somlo@cmu.edu>
> Tested-by: Gabriel Somlo <somlo@cmu.edu>
> Tested-by: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Wei Huang <wei@redhat.com>
> ---
> hw/i386/pc_piix.c | 3 +-
> hw/i386/pc_q35.c | 3 +-
> hw/smbios/smbios.c | 84 +++++++++++++++++++++++++++++++++-------------
> include/hw/smbios/smbios.h | 62 ++++++++++++++++++++++++++--------
> tests/bios-tables-test.c | 6 ++--
> 5 files changed, 116 insertions(+), 42 deletions(-)
Diffed against v4.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
(although my reviews are obviously not the bottleneck here, so I wonder
why I bother at all)
next prev parent reply other threads:[~2015-08-27 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 19:04 [Qemu-devel] [ARM SMBIOS V5 PATCH 0/2]SMBIOS Support for ARM Wei Huang
2015-08-26 19:04 ` [Qemu-devel] [ARM SMBIOS V5 PATCH 1/2] smbios: add smbios 3.0 support Wei Huang
2015-08-27 6:15 ` Laszlo Ersek [this message]
2015-09-01 15:56 ` Peter Maydell
2015-08-26 19:04 ` [Qemu-devel] [ARM SMBIOS V5 PATCH 2/2] smbios: implement smbios support for mach-virt Wei Huang
2015-09-01 15:58 ` Peter Maydell
2015-08-27 6:18 ` [Qemu-devel] [ARM SMBIOS V5 PATCH 0/2]SMBIOS Support for ARM Laszlo Ersek
2015-09-01 16:15 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DEAAFA.4050709@redhat.com \
--to=lersek@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jdelvare@suse.de \
--cc=leif.lindholm@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=roy.franz@linaro.org \
--cc=rth@twiddle.net \
--cc=somlo@cmu.edu \
--cc=wei@redhat.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).