From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUqWM-0002PZ-WE for qemu-devel@nongnu.org; Thu, 27 Aug 2015 02:18:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUqWJ-0006Hc-QJ for qemu-devel@nongnu.org; Thu, 27 Aug 2015 02:18:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUqWJ-0006HY-LC for qemu-devel@nongnu.org; Thu, 27 Aug 2015 02:18:43 -0400 References: <1440615870-9518-1-git-send-email-wei@redhat.com> From: Laszlo Ersek Message-ID: <55DEABBE.7040006@redhat.com> Date: Thu, 27 Aug 2015 08:18:38 +0200 MIME-Version: 1.0 In-Reply-To: <1440615870-9518-1-git-send-email-wei@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [ARM SMBIOS V5 PATCH 0/2]SMBIOS Support for ARM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Huang , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, drjones@redhat.com, ard.biesheuvel@linaro.org, ehabkost@redhat.com, ivan.khoronzhuk@linaro.org, mst@redhat.com, somlo@cmu.edu, zhaoshenglong@huawei.com, leif.lindholm@linaro.org, roy.franz@linaro.org, pbonzini@redhat.com, imammedo@redhat.com, jdelvare@suse.de, rth@twiddle.net On 08/26/15 21:04, Wei Huang wrote: > SMBIOS tables present userful system hardware info to management > applications, such as DMI tools. Even though SMBIOS was originally > developed for Intel x86, it has been extended to both Itanium and > ARM (32bit & 64bit). More and more ARM server releases, such as > RHEL Server for ARM, start to integrate support for SMBIOS. > > This patchset is intendted to provid SMBIOS tables for ARM mach-virt > machine. The SMBIOS tables are created and stored in fw_cfg, relying on > OVMF (AAVMF) to parse/present SMBIOS entry. > > Given that refractoring patches have been accepted by upstream. This new > version (V5) integrates SMBIOS 3.0 support for ARM mach-virt. I have > tested this version using a customized AAVMF created by Laszlo, who > has submitted his patches to OVMF mailing list. To be precise, the necessary edk2 patches have been upstream for a while. The commit range is b265ed92^..c3db5a8c. Thanks Laszlo > Compatibility tests > for x86 VMs (Linux & Windows) also passed. > > V4->V5: > * Fixed tests/bios-tables-test > * Validated with ARM64/x86-64 VMs and passed "make test" > > V3->V4: > * Patch 1 - 3 accepted by mst tree. So start from Patch 4 & 5 > * Remove ep_length; Instead infer anchor_length from anchor string (mst) > > V2->V3: > * Removed unncessary ram_size paramemter (patch 3 in V2, Laszlo) > * Fixed UUID encode (Laszlo) > * Added -smbios option (Leif) > * Fixed misc variable defintion (Laszlo) > * V2 regression tested on x86 (Gabriel and Leif) > > V1->V2: > * Add NULL checking for fw_cfg (Shannon Zhao) > * Init 3.0 entry point table max size to smbios_tables_len (Laszlo) > * Minor re-arrangement of smbios.h layout with function headers to the bottom > * Validated SMBIOS 3.0 tables with a customized AAVMF created by Laszlo > > RFC->V1: > * Add SMBIOS 3.0 support for buidling SMBIOS > * Switch from SMBIOS 2.1 to 3.0 for ARM mach-virt > * RFC version Tested-by Laszlo Ersek and Acked-by Gabriel Somlo > > Thanks, > -Wei > > Wei Huang (2): > smbios: add smbios 3.0 support > smbios: implement smbios support for mach-virt > > default-configs/arm-softmmu.mak | 1 + > hw/arm/virt.c | 25 ++++++++++++ > hw/i386/pc_piix.c | 3 +- > hw/i386/pc_q35.c | 3 +- > hw/smbios/smbios.c | 84 ++++++++++++++++++++++++++++++----------- > include/hw/smbios/smbios.h | 62 +++++++++++++++++++++++------- > qemu-options.hx | 2 +- > tests/bios-tables-test.c | 6 +-- > 8 files changed, 143 insertions(+), 43 deletions(-) >