From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57745)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZUtvx-00013G-SN
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 05:57:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZUtvt-00041R-K1
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 05:57:25 -0400
Received: from mx2.parallels.com ([199.115.105.18]:34141)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZUtvt-00040s-Eh
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 05:57:21 -0400
References: <1440632099-5169-1-git-send-email-marcandre.lureau@redhat.com>
	<1440632099-5169-13-git-send-email-marcandre.lureau@redhat.com>
	<CAJ+F1C+DRKd33KvPfbLWXcHFjPuV1HRLFYX4SB=GsDpPDq+nyQ@mail.gmail.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <55DEDEFA.3090204@openvz.org>
Date: Thu, 27 Aug 2015 12:57:14 +0300
MIME-Version: 1.0
In-Reply-To: <CAJ+F1C+DRKd33KvPfbLWXcHFjPuV1HRLFYX4SB=GsDpPDq+nyQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 12/13] qga: add --dump-conf option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@gmail.com>, QEMU <qemu-devel@nongnu.org>
Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>

On 08/27/2015 02:38 AM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Aug 27, 2015 at 1:34 AM,  <marcandre.lureau@redhat.com> wrote:
>> +    if (keyfile) {
>> +        g_key_file_free(keyfile);
>> +    }
>> +}
>
> I forgot the if () can be removed now.
>
yep...

The rest is

Reviewed-by: Denis V. Lunev <den@openvz.org>

Pls note that there is the same thing in patch 11
in

static void config_load(GAConfig *config)