From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUvLj-0006e4-49 for qemu-devel@nongnu.org; Thu, 27 Aug 2015 07:28:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUvLf-0004jg-8Z for qemu-devel@nongnu.org; Thu, 27 Aug 2015 07:28:07 -0400 Received: from mx2.parallels.com ([199.115.105.18]:41458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUvLf-0004j2-3v for qemu-devel@nongnu.org; Thu, 27 Aug 2015 07:28:03 -0400 References: <1439380232-20660-1-git-send-email-den@openvz.org> <55DC3B51.5060400@openvz.org> From: "Denis V. Lunev" Message-ID: <55DEF435.8090007@openvz.org> Date: Thu, 27 Aug 2015 14:27:49 +0300 MIME-Version: 1.0 In-Reply-To: <55DC3B51.5060400@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for 2.5 0/3] Move target- and device specific code from monitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Luiz Capitulino , qemu-devel@nongnu.org, Pavel Butsykin On 08/25/2015 12:54 PM, Denis V. Lunev wrote: > On 08/12/2015 02:50 PM, Denis V. Lunev wrote: >> The monivation of this set is simple. Recently we have proposed patch >> to monitor.c with specific x86 APIC HMP commands. The patchset was >> denied >> with the main motivation "No more arch specific code in monitor.c" >> This patchset is the first step to move arch specific code from >> monitor.c targets. >> >> So, monitor.c already contains a lot of generic code, as well as the >> target >> specifics code and eventually monitor.c volume will only grow. This >> trend leads >> to a variety of fouling code ifdeffery(and combinations thereof), >> poor readability, and entanglement of architecture of the project. >> If someone wants to improve processing logic commands at the monitor, >> it isn't necessarily must differentiate amongst the implementation of >> some ARM >> or x86_64 specific commands, because the project already has >> separation of >> target specific code on directories. >> >> The presented solution is not the best, but it is quite simple >> (PATCH doesn't add more code!) and decides the above mentioned issue. >> Subsequently it will not prevent the introduction of more advanced >> mechanism >> that can more effectively resolve the issue. >> >> There is a issue with the placement of code for multiple architectures >> (isn't for everyone), but this code is very small. This patch is a >> step towards >> solving the issue associated with maintaining the purity of the code and >> structure of the project, which solves not all, but doing a little >> better >> than it is. >> >> Changes from v1: >> - ported to new head >> >> Signed-off-by: Pavel Butsykin >> Signed-off-by: Denis V. Lunev >> CC: Luiz Capitulino >> CC: Paolo Bonzini >> CC: Peter Maydell >> > ping v2 ping v3 as per verbal discussion on KVM forum about timeouts :)