From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38784)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZUyKU-0007Eb-RE
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 10:39:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZUyKQ-0003qi-QS
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 10:39:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57098)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZUyKQ-0003qe-Kh
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 10:38:58 -0400
Message-ID: <55DF20FB.7030200@redhat.com>
Date: Thu, 27 Aug 2015 16:38:51 +0200
From: Thomas Huth <thuth@redhat.com>
MIME-Version: 1.0
References: <1440583182-5828-1-git-send-email-yanghy@cn.fujitsu.com>
	<1440583182-5828-6-git-send-email-yanghy@cn.fujitsu.com>
In-Reply-To: <1440583182-5828-6-git-send-email-yanghy@cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v8 05/11] move out net queue structs define
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, mrhines@linux.vnet.ibm.com, stefanha@redhat.com


Maybe add a short comment why/where this is needed later?

On 26/08/15 11:59, Yang Hongyang wrote:
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> ---
>  include/net/queue.h | 19 +++++++++++++++++++
>  net/queue.c         | 19 -------------------
>  2 files changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/include/net/queue.h b/include/net/queue.h
> index fc02b33..1d65e47 100644
> --- a/include/net/queue.h
> +++ b/include/net/queue.h
> @@ -31,6 +31,25 @@ typedef struct NetQueue NetQueue;
>  
>  typedef void (NetPacketSent) (NetClientState *sender, ssize_t ret);
>  
> +struct NetPacket {
> +    QTAILQ_ENTRY(NetPacket) entry;
> +    NetClientState *sender;
> +    unsigned flags;
> +    int size;
> +    NetPacketSent *sent_cb;
> +    uint8_t data[0];
> +};
> +
> +struct NetQueue {
> +    void *opaque;
> +    uint32_t nq_maxlen;
> +    uint32_t nq_count;
> +
> +    QTAILQ_HEAD(packets, NetPacket) packets;
> +
> +    unsigned delivering:1;
> +};
> +
>  #define QEMU_NET_PACKET_FLAG_NONE  0
>  #define QEMU_NET_PACKET_FLAG_RAW  (1<<0)
>  
> diff --git a/net/queue.c b/net/queue.c
> index ebbe2bb..1499479 100644
> --- a/net/queue.c
> +++ b/net/queue.c
> @@ -39,25 +39,6 @@
>   * unbounded queueing.
>   */
>  
> -struct NetPacket {
> -    QTAILQ_ENTRY(NetPacket) entry;
> -    NetClientState *sender;
> -    unsigned flags;
> -    int size;
> -    NetPacketSent *sent_cb;
> -    uint8_t data[0];
> -};
> -
> -struct NetQueue {
> -    void *opaque;
> -    uint32_t nq_maxlen;
> -    uint32_t nq_count;
> -
> -    QTAILQ_HEAD(packets, NetPacket) packets;
> -
> -    unsigned delivering : 1;
> -};
> -
>  NetQueue *qemu_new_net_queue(void *opaque)
>  {
>      NetQueue *queue;

Reviewed-by: Thomas Huth <thuth@redhat.com>