From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUyS7-0002XO-Sa for qemu-devel@nongnu.org; Thu, 27 Aug 2015 10:47:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUyS4-0006yu-NL for qemu-devel@nongnu.org; Thu, 27 Aug 2015 10:46:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUyS4-0006yO-IB for qemu-devel@nongnu.org; Thu, 27 Aug 2015 10:46:52 -0400 Message-ID: <55DF22D6.6000209@redhat.com> Date: Thu, 27 Aug 2015 16:46:46 +0200 From: Thomas Huth MIME-Version: 1.0 References: <1440583182-5828-1-git-send-email-yanghy@cn.fujitsu.com> <1440583182-5828-8-git-send-email-yanghy@cn.fujitsu.com> In-Reply-To: <1440583182-5828-8-git-send-email-yanghy@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 07/11] netfilter: print filter info associate with the netdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, mrhines@linux.vnet.ibm.com, Yang Hongyang , stefanha@redhat.com On 26/08/15 11:59, Yang Hongyang wrote: > From: Yang Hongyang > > When execute "info network", print filter info also. > current info printed is simple, can add more info later. > > Signed-off-by: Yang Hongyang > --- > v7: initial patch > --- > include/net/filter.h | 1 + > net/filter.c | 22 ++++++++++++++++++++++ > net/net.c | 11 +++++++++++ > 3 files changed, 34 insertions(+) > > diff --git a/include/net/filter.h b/include/net/filter.h > index 9278d40..188ecb1 100644 > --- a/include/net/filter.h > +++ b/include/net/filter.h > @@ -56,6 +56,7 @@ NetFilterState *qemu_new_net_filter(NetFilterInfo *info, > void qemu_del_net_filter(NetFilterState *nf); > void netfilter_add(QemuOpts *opts, Error **errp); > void qmp_netfilter_add(QDict *qdict, QObject **ret, Error **errp); > +const char *qemu_netfilter_get_chain_str(int chain); > > /* pass the packet to the next filter */ > ssize_t qemu_netfilter_pass_to_next(NetFilterState *nf, NetPacket *packet); > diff --git a/net/filter.c b/net/filter.c > index 44c17b0..76e12ea 100644 > --- a/net/filter.c > +++ b/net/filter.c > @@ -23,6 +23,28 @@ > > static QTAILQ_HEAD(, NetFilterState) net_filters; > > +const char *qemu_netfilter_get_chain_str(int chain) > +{ > + const char *str = NULL; The "= NULL" is not necessary here - the default case below should handle this. > + switch (chain) { > + case NET_FILTER_IN: > + str = "in"; > + break; > + case NET_FILTER_OUT: > + str = "out"; > + break; > + case NET_FILTER_ALL: > + str = "all"; > + break; > + default: > + str = "unknown"; > + break; > + } > + > + return str; > +} Thomas