Re: [Qemu-devel] [PATCH v8 08/11] net/queue: export qemu_net_queue_append_iov

[Thomas Huth <thuth@redhat.com>]

Maybe add a short description why/where this will be needed?

On 26/08/15 11:59, Yang Hongyang wrote:
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> ---
>  include/net/queue.h |  7 +++++++
>  net/queue.c         | 12 ++++++------
>  2 files changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/include/net/queue.h b/include/net/queue.h
> index 1d65e47..e139cc7 100644
> --- a/include/net/queue.h
> +++ b/include/net/queue.h
> @@ -55,6 +55,13 @@ struct NetQueue {
>  
>  NetQueue *qemu_new_net_queue(void *opaque);
>  
> +void qemu_net_queue_append_iov(NetQueue *queue,
> +                               NetClientState *sender,
> +                               unsigned flags,
> +                               const struct iovec *iov,
> +                               int iovcnt,
> +                               NetPacketSent *sent_cb);
> +
>  void qemu_del_net_queue(NetQueue *queue);
>  
>  ssize_t qemu_net_queue_send(NetQueue *queue,
> diff --git a/net/queue.c b/net/queue.c
> index 1499479..428fdd6 100644
> --- a/net/queue.c
> +++ b/net/queue.c
> @@ -91,12 +91,12 @@ static void qemu_net_queue_append(NetQueue *queue,
>      QTAILQ_INSERT_TAIL(&queue->packets, packet, entry);
>  }
>  
> -static void qemu_net_queue_append_iov(NetQueue *queue,
> -                                      NetClientState *sender,
> -                                      unsigned flags,
> -                                      const struct iovec *iov,
> -                                      int iovcnt,
> -                                      NetPacketSent *sent_cb)
> +void qemu_net_queue_append_iov(NetQueue *queue,
> +                               NetClientState *sender,
> +                               unsigned flags,
> +                               const struct iovec *iov,
> +                               int iovcnt,
> +                               NetPacketSent *sent_cb)
>  {
>      NetPacket *packet;
>      size_t max_len = 0;
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>