From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUyk7-0000de-Hc for qemu-devel@nongnu.org; Thu, 27 Aug 2015 11:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUyk3-0002KP-Jp for qemu-devel@nongnu.org; Thu, 27 Aug 2015 11:05:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUyk3-0002K8-Du for qemu-devel@nongnu.org; Thu, 27 Aug 2015 11:05:27 -0400 Message-ID: <55DF2730.2090606@redhat.com> Date: Thu, 27 Aug 2015 17:05:20 +0200 From: Thomas Huth MIME-Version: 1.0 References: <1440583182-5828-1-git-send-email-yanghy@cn.fujitsu.com> <1440583182-5828-9-git-send-email-yanghy@cn.fujitsu.com> In-Reply-To: <1440583182-5828-9-git-send-email-yanghy@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 08/11] net/queue: export qemu_net_queue_append_iov List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, mrhines@linux.vnet.ibm.com, stefanha@redhat.com Maybe add a short description why/where this will be needed? On 26/08/15 11:59, Yang Hongyang wrote: > Signed-off-by: Yang Hongyang > --- > include/net/queue.h | 7 +++++++ > net/queue.c | 12 ++++++------ > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/include/net/queue.h b/include/net/queue.h > index 1d65e47..e139cc7 100644 > --- a/include/net/queue.h > +++ b/include/net/queue.h > @@ -55,6 +55,13 @@ struct NetQueue { > > NetQueue *qemu_new_net_queue(void *opaque); > > +void qemu_net_queue_append_iov(NetQueue *queue, > + NetClientState *sender, > + unsigned flags, > + const struct iovec *iov, > + int iovcnt, > + NetPacketSent *sent_cb); > + > void qemu_del_net_queue(NetQueue *queue); > > ssize_t qemu_net_queue_send(NetQueue *queue, > diff --git a/net/queue.c b/net/queue.c > index 1499479..428fdd6 100644 > --- a/net/queue.c > +++ b/net/queue.c > @@ -91,12 +91,12 @@ static void qemu_net_queue_append(NetQueue *queue, > QTAILQ_INSERT_TAIL(&queue->packets, packet, entry); > } > > -static void qemu_net_queue_append_iov(NetQueue *queue, > - NetClientState *sender, > - unsigned flags, > - const struct iovec *iov, > - int iovcnt, > - NetPacketSent *sent_cb) > +void qemu_net_queue_append_iov(NetQueue *queue, > + NetClientState *sender, > + unsigned flags, > + const struct iovec *iov, > + int iovcnt, > + NetPacketSent *sent_cb) > { > NetPacket *packet; > size_t max_len = 0; > Reviewed-by: Thomas Huth