From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUzjM-0006n8-TK for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:08:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUzjL-0007tY-NM for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:08:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUzjL-0007tR-Iu for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:08:47 -0400 References: <20150826220151.GA2669@localhost.localdomain> <2CB0CE30-A638-4933-A1D6-F65CA4910E61@gmail.com> <20150827123234.GB2669@localhost.localdomain> <56530C98-D6B3-417E-BB58-E29412283BF1@gmail.com> <20150827140707.GD2669@localhost.localdomain> <4E7FD2A3-C967-4D30-A657-548D27BCC84B@gmail.com> <20150827151924.GY24486@redhat.com> <96F6061A-2DEB-440D-BB80-B300CA27BDEE@gmail.com> <20150827155527.GZ24486@redhat.com> <20150827160623.GB24486@redhat.com> From: Eric Blake Message-ID: <55DF360D.6050201@redhat.com> Date: Thu, 27 Aug 2015 10:08:45 -0600 MIME-Version: 1.0 In-Reply-To: <20150827160623.GB24486@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TvKmEIFBjwhts1US2aULiIo4KWjgMGI8b" Subject: Re: [Qemu-devel] Should we auto-generate IDs? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Programmingkid Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , qemu-devel qemu-devel , Paolo Bonzini , jsnow@redhat.com, =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TvKmEIFBjwhts1US2aULiIo4KWjgMGI8b Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/27/2015 10:06 AM, Daniel P. Berrange wrote: >> >> I applied your patch, but saw this error message when I tried to 'make= ' QEMU: >> >> GEN qmp-commands.txt >> line 344: syntax error: expected EQMP, found SQMP >> make: *** [qmp-commands.txt] Error 1 >> make: *** Deleting file `qmp-commands.txt' >> >> Know what it means? >=20 > It means I should have run 'make' again after adding the documentation > to detect the bug :-) I'll send another patch.... Generally, it's nicer to reply about problems with a patch to the patch itself, rather than in an unrelated thread. Makes it easier for maintainers to see that a v2 of the patch will be needed. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TvKmEIFBjwhts1US2aULiIo4KWjgMGI8b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV3zYNAAoJEKeha0olJ0Nqd98IAIdWvRPi+2XxREQi/aUKRXiw M/CkpzC9YRfjFxBwPpJyNt413pc8EMQ+cudFY7jAPqYIpHwk7IPpUPO8uJYetlA+ peSLnMVNxYFzPHeSWbYGYmQdtvZD9uHlM2PvqT5A4Oby1nE+J8j+0t/d3O0AX8Wv /nD7P/qCWVggixhFYSeW+00AF0Pz15u1Lmg5dq7GeDtgQhCmuqpn702LRnrK0yx1 UOAtaN3Rsk05YfeoBcH1FZB7j1UU3s56dEYTFpmRsYzcqO3hT383C0UZm7/p0eqQ vgt8cXXq+FAxWspuPK2nR40TRKBrFmymxHamlOazh0YmRIS246StRapIUqhFt+U= =GdrT -----END PGP SIGNATURE----- --TvKmEIFBjwhts1US2aULiIo4KWjgMGI8b--