From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUzwm-0007H1-Rn for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:22:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUzwj-0008SP-Nl for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:22:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUzwj-0008SI-Ic for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:22:37 -0400 References: <1440691994-4547-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <55DF3947.10008@redhat.com> Date: Thu, 27 Aug 2015 10:22:31 -0600 MIME-Version: 1.0 In-Reply-To: <1440691994-4547-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fW1cPgHb6iViIGID271uWCI8G6SGuB55T" Subject: Re: [Qemu-devel] [PATCH v2] monitor: allow object_del & device_del to accept QOM paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Programmingkid , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fW1cPgHb6iViIGID271uWCI8G6SGuB55T Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/27/2015 10:13 AM, Daniel P. Berrange wrote: > Currently both object_del and device_del require that the > client provide the object/device short ID. While user > creatable objects require an ID to be provided at time of > creation, qdev devices may be created without giving an > ID. The only unique identifier they would then have is the > QOM object path. >=20 > Allowing device_del to accept an object path ensures all > devices are deletable regardless of whether they have an > ID. >=20 > (qemu) device_add usb-mouse > (qemu) qom-list /machine/peripheral-anon > device[0] (child) > type (string) > (qemu) device_del /machine/peripheral-anon/device[0] >=20 > Although objects require an ID to be provided upfront, > there may be cases where the client would prefer to > use QOM paths when deleting. >=20 > Signed-off-by: Daniel P. Berrange > --- > hmp-commands.hx | 6 ++++-- > qapi-schema.json | 4 ++-- > qdev-monitor.c | 14 +++++++++----- > qmp-commands.hx | 13 +++++++++++-- > qmp.c | 10 +++++++--- > 5 files changed, 33 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fW1cPgHb6iViIGID271uWCI8G6SGuB55T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV3zlHAAoJEKeha0olJ0NqEW4IAIfJPCKiVEKkNKxUdKhYWswA I20qt6lqFBhFsajS0d1ThZ3wrbU8UIhI6uTM3KW8RUZNZl02Y+welgGOUpg1AiJ9 XWXQmj3EqIxrpbmIn2kiIzRovsA31JF44QjRtxjzYsNwx/JyDgfgh+4vkHU1s6JI Xr1n9bHm1iyiNTDacsWzzEdDyGLmvaeHtG9Pf7hLwPLPPGizeqdG40IxsmIgoji1 lQbJjFO6O6cJCC4VcJ/jXRPcvJMKtMVTJ5mM61nL1vsWW45wiootB5W4M6SPe6yS bfeS5ziBh98OI4PDRUNc3oET5TrKK1dAJ5Sq/AdRtmxUOh7z2Oi58OKm9PuGrKc= =wH73 -----END PGP SIGNATURE----- --fW1cPgHb6iViIGID271uWCI8G6SGuB55T--