From: Richard Henderson <rth@twiddle.net>
To: "Andreas Färber" <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Claudio Fontana <claudio.fontana@huawei.com>,
"v2.4.0" <qemu-stable@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user
Date: Thu, 27 Aug 2015 21:30:04 -0700 [thread overview]
Message-ID: <55DFE3CC.4030806@twiddle.net> (raw)
In-Reply-To: <1440719254-12349-1-git-send-email-afaerber@suse.de>
On 08/27/2015 04:47 PM, Andreas Färber wrote:
> The argument order for the !CONFIG_SOFTMMU case was jumbled up since
> ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit
> offset for 32-bit user-mode emulation"), regressing from -rc2 to v2.4.0.
> Fix their order to avoid segfaults, e.g., in openSUSE's GNU coreutils 8.24.
Nack. The argument order is correct, that is...
> - tcg_out_qemu_ld_direct(s, memop, ext, data_reg,
> - guest_base ? TCG_REG_GUEST_BASE : TCG_REG_XZR,
> - otype, addr_reg);
> + tcg_out_qemu_ld_direct(s, memop, ext, data_reg, addr_reg, otype,
> + guest_base ? TCG_REG_GUEST_BASE : TCG_REG_XZR);
TCG_REG_GUEST_BASE is definitely the "base" register, holding a 64-bit host
address, while addr_reg is the "offset" register, holding a (potentially)
32-bit guest address. It is (supposed to be) the "offset" register to which
the zero-extend is applied.
If something's wrong, and I'm not currently in a position to verify one way or
another, it's in tcg_out_insn_3310.
r~
next prev parent reply other threads:[~2015-08-28 4:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 23:47 [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user Andreas Färber
2015-08-28 4:30 ` Richard Henderson [this message]
2015-08-28 16:23 ` Andreas Färber
2015-08-29 5:33 ` Richard Henderson
2015-08-29 6:50 ` Paolo Bonzini
2015-09-01 16:31 ` Andreas Färber
2015-09-01 20:09 ` Richard Henderson
2015-09-02 9:02 ` Paolo Bonzini
2015-09-02 14:26 ` Richard Henderson
2015-09-02 14:38 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DFE3CC.4030806@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=claudio.fontana@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).