From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVF6M-0003af-7m for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:33:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVF6I-0000AJ-Um for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:33:34 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:65343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVF6I-0000AB-Na for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:33:30 -0400 References: <1440445026-26522-1-git-send-email-rth@twiddle.net> <1440445026-26522-19-git-send-email-rth@twiddle.net> <20150828102150.4b1c3e6d.cornelia.huck@de.ibm.com> From: Laurent Vivier Message-ID: <55E01CD5.40002@vivier.eu> Date: Fri, 28 Aug 2015 10:33:25 +0200 MIME-Version: 1.0 In-Reply-To: <20150828102150.4b1c3e6d.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 18/18] linux-user: remove useless macros GUEST_BASE and RESERVED_VA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org Le 28/08/2015 10:21, Cornelia Huck a écrit : > On Mon, 24 Aug 2015 12:37:06 -0700 > Richard Henderson wrote: > >> From: Laurent Vivier >> >> As we have removed CONFIG_USE_GUEST_BASE, we always use a guest base >> and the macros GUEST_BASE and RESERVED_VA become useless: replace >> them by their values. >> >> Reviewed-by: Alexander Graf >> Signed-off-by: Laurent Vivier >> Message-Id: <1440420834-8388-1-git-send-email-laurent@vivier.eu> >> Signed-off-by: Richard Henderson >> --- >> include/exec/cpu-all.h | 4 +--- >> include/exec/cpu_ldst.h | 8 ++++---- >> linux-user/mmap.c | 20 ++++++++++---------- >> tcg/aarch64/tcg-target.c | 10 +++++----- >> tcg/arm/tcg-target.c | 8 ++++---- >> tcg/i386/tcg-target.c | 22 +++++++++++----------- >> tcg/ia64/tcg-target.c | 21 +++++++++------------ >> tcg/mips/tcg-target.c | 16 ++++++++-------- >> tcg/ppc/tcg-target.c | 12 ++++-------- >> tcg/s390/tcg-target.c | 13 ++++--------- >> tcg/sparc/tcg-target.c | 8 ++++---- >> 11 files changed, 64 insertions(+), 78 deletions(-) > > This seems to break compilation on s390 for me: > > In file included from /home/cohuck/git/qemu/tcg/tcg.c:258:0: > /home/cohuck/git/qemu/tcg/s390/tcg-target.c: In function ‘tcg_target_qemu_prologue’: > /home/cohuck/git/qemu/tcg/s390/tcg-target.c:2347:9: error: ‘guest_base’ undeclared (first use in this function) > if (guest_base >= 0x80000) { > ^ > (once for each of the softmmu subdirs I build) > > config.log says: > > # Configured with: '/home/cohuck/git/qemu/build/../configure' '--target-list=s390x-softmmu s390x-linux-user aarch64-softmmu arm-softmmu mips-softmmu ppc-softmmu ppc64-softmmu' '--enable-kvm' '--enable-vhost-net' '--enable-virtio-blk-data-plane' '--enable-linux-aio' I've tested the compilation for all targets but only on x86_64... :( The use of guest_base must be surrounded by "#ifndef CONFIG_SOFTMMU", it is not the case for s390 (see other host tcg). Can you fix this or do you want I write a patch ? Laurent