From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVFNH-0003Do-GG for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVFNC-0008DA-DU for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:51:03 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:37408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVFNC-0008Ct-6B for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:50:58 -0400 Received: by wicfv10 with SMTP id fv10so5375262wic.0 for ; Fri, 28 Aug 2015 01:50:56 -0700 (PDT) Sender: Paolo Bonzini References: <1440548265-4755-1-git-send-email-pbonzini@redhat.com> <1440548265-4755-7-git-send-email-pbonzini@redhat.com> <20150828021954.GA25092@flamenco> From: Paolo Bonzini Message-ID: <55E020F1.1030904@redhat.com> Date: Fri, 28 Aug 2015 10:50:57 +0200 MIME-Version: 1.0 In-Reply-To: <20150828021954.GA25092@flamenco> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/9] tcg: synchronize cpu->exit_request and cpu->tcg_exit_req accesses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" Cc: mttcg@greensocs.com, qemu-devel@nongnu.org, rth@twiddle.net On 28/08/2015 04:19, Emilio G. Cota wrote: > translate-all.c-1478- } else { > translate-all.c:1479: cpu->tcg_exit_req = 1; This one is only run in the CPU thread. > translate-all.c-1643- cpu->interrupt_request |= mask; > translate-all.c:1644: cpu->tcg_exit_req = 1; This one is only run in user-mode emulation, which also means it is run in the CPU thread. Paolo > Current master certainly doesn't have them, but I wonder if > you have barriers at those places in the tree you're working on. If not > I'd expand this patch to add them.