From: Laurent Vivier <laurent@vivier.eu>
To: Peter Maydell <peter.maydell@linaro.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] s390: fix softmmu compilation
Date: Fri, 28 Aug 2015 12:13:17 +0200 [thread overview]
Message-ID: <55E0343D.2080309@vivier.eu> (raw)
In-Reply-To: <CAFEAcA_XGNNxRGVLHLY5a=mSXK7UQabbRq4FgCo5VidGsW9XGg@mail.gmail.com>
Le 28/08/2015 12:08, Peter Maydell a écrit :
> On 28 August 2015 at 11:03, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 28 August 2015 at 10:15, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>>> On Fri, 28 Aug 2015 11:09:05 +0200
>>> Laurent Vivier <laurent@vivier.eu> wrote:
>>>
>>>> guest_base must be used only in linux-user mode.
>>>>
>>>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>>>> ---
>>>> tcg/s390/tcg-target.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>
>>> Thanks, that fixed compilation on s390 for me.
>>
>> I'm planning to apply this directly to master as a buildfix.
>
> Incidentally, minor cleanup now possible: TCG_GUEST_BASE_REG
> is now only used inside ifndef CONFIG_SOFTMMU, so you can drop
> the #define of it to TCG_REG_R0 in the softmmu case.
You're right I send a v2...
Laurent
prev parent reply other threads:[~2015-08-28 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 9:09 [Qemu-devel] [PATCH] s390: fix softmmu compilation Laurent Vivier
2015-08-28 9:15 ` Cornelia Huck
2015-08-28 10:03 ` Peter Maydell
2015-08-28 10:08 ` Peter Maydell
2015-08-28 10:13 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E0343D.2080309@vivier.eu \
--to=laurent@vivier.eu \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).