From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36153)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZVGf3-0001hz-Uc
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 06:13:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZVGey-00026m-Sq
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 06:13:29 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:64675)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZVGey-00026f-MX
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 06:13:24 -0400
References: <1440752945-4514-1-git-send-email-laurent@vivier.eu>
	<20150828111535.3e48a9b9.cornelia.huck@de.ibm.com>
	<CAFEAcA_+x+D1GF-361Xw6UX0WMDUvcrJ6z645J_ppaPA55ugow@mail.gmail.com>
	<CAFEAcA_XGNNxRGVLHLY5a=mSXK7UQabbRq4FgCo5VidGsW9XGg@mail.gmail.com>
From: Laurent Vivier <laurent@vivier.eu>
Message-ID: <55E0343D.2080309@vivier.eu>
Date: Fri, 28 Aug 2015 12:13:17 +0200
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_XGNNxRGVLHLY5a=mSXK7UQabbRq4FgCo5VidGsW9XGg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] s390: fix softmmu compilation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Richard Henderson <rth@twiddle.net>



Le 28/08/2015 12:08, Peter Maydell a écrit :
> On 28 August 2015 at 11:03, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 28 August 2015 at 10:15, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>>> On Fri, 28 Aug 2015 11:09:05 +0200
>>> Laurent Vivier <laurent@vivier.eu> wrote:
>>>
>>>> guest_base must be used only in linux-user mode.
>>>>
>>>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>>>> ---
>>>>  tcg/s390/tcg-target.c | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>
>>> Thanks, that fixed compilation on s390 for me.
>>
>> I'm planning to apply this directly to master as a buildfix.
> 
> Incidentally, minor cleanup now possible: TCG_GUEST_BASE_REG
> is now only used inside ifndef CONFIG_SOFTMMU, so you can drop
> the #define of it to TCG_REG_R0 in the softmmu case.

You're right I send a v2...

Laurent