From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVL3U-0000qR-KD for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:55:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVL3R-0004Qm-6T for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:55:00 -0400 Received: from mx2.parallels.com ([199.115.105.18]:40622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVL3Q-0004QX-Tr for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:54:57 -0400 Message-ID: <55E07604.8060902@odin.com> Date: Fri, 28 Aug 2015 17:53:56 +0300 From: Pavel Butsykin MIME-Version: 1.0 References: <1439380232-20660-1-git-send-email-den@openvz.org> <1439380232-20660-4-git-send-email-den@openvz.org> <55E006FF.7090307@odin.com> In-Reply-To: Content-Type: multipart/alternative; boundary="------------030808030204050102050600" Subject: Re: [Qemu-devel] [PATCH 3/3] monitor: added generation of documentation for hmp-commands-info.hx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Denis V. Lunev" , Luiz Capitulino , QEMU Developers , Paolo Bonzini , Pavel Butsykin --------------030808030204050102050600 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 28.08.2015 11:19, Peter Maydell wrote: > On 28 August 2015 at 08:00, Pavel Butsykin wrote: >> >> On 27.08.2015 20:39, Peter Maydell wrote: >>> On 12 August 2015 at 12:50, Denis V. Lunev wrote: >>>> From: Pavel Butsykin >>>> >>>> It will be easier if you need to add info-commands to edit >>>> only hmp-commands-info.hx, before this had to edit monitor.c and >>>> hmp-commands.hx >>>> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx >>>> index 9ccb33f..81ae9d7 100644 >>>> --- a/hmp-commands-info.hx >>>> +++ b/hmp-commands-info.hx >>>> @@ -6,6 +6,9 @@ HXCOMM monitor info commands >>>> HXCOMM HXCOMM can be used for comments, discarded from both texi and C >>>> >>>> STEXI >>>> +@item info @var{subcommand} >>>> +@findex info >>>> +Show various information about the system state. >>>> @table @option >>>> ETEXI >>>> >>>> @@ -708,4 +711,5 @@ ETEXI >>>> >>>> STEXI >>>> @end table >>>> +@end table >>>> ETEXI >>> Where does this extra "@end table" come from? >>> >>> thanks >>> -- PMM >> This "@end table" come from hmp-commands.hx and it's necessary to close tag >> "@subsection Commands" from qemu-doc.texi > If the tag is opened in qemu-doc.texi then I think > qemu-doc.texi ought to be responsible for closing it. > > This may be related to a bug in the docs (as they are > in master) where we close the table too early and so > the 'info trace-events' and rocker related info subcommands > aren't indented properly. (Also the rocker subcommands > don't say "info $subcommand" the way the others do.) > > thanks > -- PMM You're right, the "@subsection Commands" is not required to close :) I'll fix it, thanks. --------------030808030204050102050600 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

On 28.08.2015 11:19, Peter Maydell wrote:
On 28 August 2015 at 08:00, Pavel Butsykin <pbutsykin@odin.com> wrote:


On 27.08.2015 20:39, Peter Maydell wrote:

On 12 August 2015 at 12:50, Denis V. Lunev <den@openvz.org> wrote:

From: Pavel Butsykin <pbutsykin@virtuozzo.com>

It will be easier if you need to add info-commands to edit
only hmp-commands-info.hx, before this had to edit monitor.c and
hmp-commands.hx


      

        

          

            
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
index 9ccb33f..81ae9d7 100644
--- a/hmp-commands-info.hx
+++ b/hmp-commands-info.hx
@@ -6,6 +6,9 @@ HXCOMM monitor info commands
  HXCOMM HXCOMM can be used for comments, discarded from both texi and C

  STEXI
+@item info @var{subcommand}
+@findex info
+Show various information about the system state.
  @table @option
  ETEXI

@@ -708,4 +711,5 @@ ETEXI

  STEXI
  @end table
+@end table
  ETEXI


          

          
Where does this extra "@end table" come from?

thanks
-- PMM


        

        
This "@end table" come from hmp-commands.hx and it's necessary to close tag
"@subsection Commands" from qemu-doc.texi


      

      
If the tag is opened in qemu-doc.texi then I think
qemu-doc.texi ought to be responsible for closing it.

This may be related to a bug in the docs (as they are
in master) where we close the table too early and so
the 'info trace-events' and rocker related info subcommands
aren't indented properly. (Also the rocker subcommands
don't say "info $subcommand" the way the others do.)

thanks
-- PMM


    

    
    You're right, the "@subsection Commands" is not required to close :)
    I'll fix it, thanks.
    
  


--------------030808030204050102050600--