From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46937)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbutsykin@odin.com>) id 1ZVL7x-00052q-Q4
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:59:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbutsykin@odin.com>) id 1ZVL7u-0007VI-I6
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:59:37 -0400
Received: from mx2.parallels.com ([199.115.105.18]:40898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbutsykin@odin.com>) id 1ZVL7u-0007VE-Bv
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 10:59:34 -0400
Message-ID: <55E07717.50807@odin.com>
Date: Fri, 28 Aug 2015 17:58:31 +0300
From: Pavel Butsykin <pbutsykin@odin.com>
MIME-Version: 1.0
References: <1439380232-20660-1-git-send-email-den@openvz.org>
	<1439380232-20660-3-git-send-email-den@openvz.org>
	<CAFEAcA8ZQGG23brMj_AU87wGLAueLWJbkiBy5DZePW7LyVbFVg@mail.gmail.com>
	<55E02829.6040805@odin.com>
	<CAFEAcA8Ujhs=g7g_kBCGJTF4BhKwn4Nx7WX3-LeSMLwoX0AHAg@mail.gmail.com>
In-Reply-To: <CAFEAcA8Ujhs=g7g_kBCGJTF4BhKwn4Nx7WX3-LeSMLwoX0AHAg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code
	from monitor.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Denis V. Lunev" <den@openvz.org>, Luiz Capitulino <lcapitulino@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Pavel Butsykin <pbutsykin@virtuozzo.com>



On 28.08.2015 13:12, Peter Maydell wrote:
> On 28 August 2015 at 10:21, Pavel Butsykin <pbutsykin@odin.com> wrote:
>> Yes, this is a good way if we make the interface: const MonitorDef
>> *target_monitor_defs(void);
>> But we can't include the 'monitor/monitor-common.h' to
>> stubs/target-monitor-defs.c, because
>> there is a dependency with a target-specific headers( such as
>> cpu.h:CPUArchState, cpu-defs.h:target_long).
>> Make a copy of the struct MonitorDef not a good way because we can miss the
>> change of copied MonitorDef
>> in stubs/target-monitor-defs.c and this will result in an bug. Can this be
>> solved somehow else?
> That target_long is awkward. I suggest making the stub version
> just return NULL rather than a pointer to an empty list (you'll
> need to adjust the calling code slightly to handle the NULL
> return). Then the stub code only needs to be able to see the
> 'typedef struct MonitorDef MonitorDef' (which you can put in
> qemu-typedefs.h).
>
> -- PMM
Thank you for the suggestion, this seems a good way out.