From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVQtG-0003xR-UF for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:08:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVQtD-0004eN-Oh for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:08:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVQtD-0004e8-J3 for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:08:47 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A85A38F020 for ; Fri, 28 Aug 2015 21:08:46 +0000 (UTC) References: <1440601524-30316-1-git-send-email-berrange@redhat.com> <1440601524-30316-9-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <55E0CDD9.1040305@redhat.com> Date: Fri, 28 Aug 2015 15:08:41 -0600 MIME-Version: 1.0 In-Reply-To: <1440601524-30316-9-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VFxcBVKpADBUs9Tei6xQarkk2Sch1oge0" Subject: Re: [Qemu-devel] [PATCH v5 8/9] ui: fix return type for VNC I/O functions to be ssize_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VFxcBVKpADBUs9Tei6xQarkk2Sch1oge0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/26/2015 09:05 AM, Daniel P. Berrange wrote: > Various VNC server I/O functions return 'long' and then > also pass this to a method accepting 'int'. All these > should be ssize_t to match the signature of read/write > APIs and thus avoid potential for integer truncation / > wraparound. >=20 > Signed-off-by: Daniel P. Berrange > --- > ui/vnc.c | 36 ++++++++++++++++++------------------ > ui/vnc.h | 6 +++--- > 2 files changed, 21 insertions(+), 21 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VFxcBVKpADBUs9Tei6xQarkk2Sch1oge0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV4M3ZAAoJEKeha0olJ0NqxYwIAKDJ1/hJngqMKbh7fKxYhD4e uoYB/TUS9Gd1KvyskuxZJyx+hYTxNj7mmq9ExWrTyoR0eHkECzRdWbvIXFgvBgez uZBmRJvgBauSx7IPRythXiv0lTPk+zFQX02ZiXo+WuM8mPJA7mM+pLKOsbusyBTH FASDUoRcxH1/C3kRWZ4zUdpXNnpQG7ExVsJjunYTw/PkNKHImHNPgoDFNL+LMnES nHDQYrvOiHVGOdHCCL5/PH8/c5QXGDNSPLPPxZte5nDIOPqB1VjXUZXJ7BczVSYO rX9qzmVX28w+UdlOWSHPu88KuFvZwWWUTvCpWEVXzj5r/Dxh7roxMcr9K1bqRLo= =OOmF -----END PGP SIGNATURE----- --VFxcBVKpADBUs9Tei6xQarkk2Sch1oge0--