From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVRcd-0000sJ-Uk for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVRca-0006C0-Hz for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:55:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVRca-0006Bt-B2 for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:55:40 -0400 References: <1438159544-6224-1-git-send-email-zhang.zhanghailiang@huawei.com> <1438159544-6224-7-git-send-email-zhang.zhanghailiang@huawei.com> From: Eric Blake Message-ID: <55E0D8DA.207@redhat.com> Date: Fri, 28 Aug 2015 15:55:38 -0600 MIME-Version: 1.0 In-Reply-To: <1438159544-6224-7-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ndkN2BLda8eKpP6GtXfJjv5aRBavsx2hq" Subject: Re: [Qemu-devel] [PATCH COLO-Frame v8 06/34] migration: Integrate COLO checkpoint process into migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, amit.shah@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ndkN2BLda8eKpP6GtXfJjv5aRBavsx2hq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/29/2015 02:45 AM, zhanghailiang wrote: > Add a migrate state: MIGRATION_STATUS_COLO, enter this migration state > after the first live migration successfully finished. >=20 > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > --- > include/migration/colo.h | 3 +++ > migration/colo.c | 58 ++++++++++++++++++++++++++++++++++++++++= ++++++++ > migration/migration.c | 23 ++++++++++++++----- > qapi-schema.json | 2 +- > stubs/migration-colo.c | 9 ++++++++ > trace-events | 3 +++ > 6 files changed, 92 insertions(+), 6 deletions(-) >=20 Just an interface review. > +++ b/qapi-schema.json > @@ -433,7 +433,7 @@ > ## > { 'enum': 'MigrationStatus', > 'data': [ 'none', 'setup', 'cancelling', 'cancelled', > - 'active', 'completed', 'failed' ] } > + 'active', 'completed', 'failed', 'colo' ] } Missing documentation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ndkN2BLda8eKpP6GtXfJjv5aRBavsx2hq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV4NjaAAoJEKeha0olJ0Nqy0AIAJ6WXD0sYLWg0Ols2gWWMApH VLZL6DKvRsDrrY/titNgqNhkusKYY3ysBzIIE/mCvcxBtHvZD6kCwHE50eq/NNvQ xcGsmoMM3mgD8PjMcmRhJfXZQeAvsO4oE70eBnhyShCzZLxeqXVhRwWVc3l1/j8D Xanz9xTmFMrW99GUDlZRplkCV0AntiFMDOjuSTPXDZQtdrIUgezjTM0KxtS1HRNa R8gnpKgWAY+BmiNn9p4A80NSKFK8jrT8zB2X3FqxiSRMWYxG5Ee3TZ8ME01+388J O86cpjZIcWvGUOCPZhOhwFMB1BuSfMY9LF/wCDb1h1DFekKrU/sRQe7LGK5SJBA= =A1s6 -----END PGP SIGNATURE----- --ndkN2BLda8eKpP6GtXfJjv5aRBavsx2hq--