From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVRfc-0002Tn-JT for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:58:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVRfZ-0007FE-Af for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:58:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVRfZ-0007FA-5N for qemu-devel@nongnu.org; Fri, 28 Aug 2015 17:58:45 -0400 References: <1438159544-6224-1-git-send-email-zhang.zhanghailiang@huawei.com> <1438159544-6224-10-git-send-email-zhang.zhanghailiang@huawei.com> From: Eric Blake Message-ID: <55E0D992.40503@redhat.com> Date: Fri, 28 Aug 2015 15:58:42 -0600 MIME-Version: 1.0 In-Reply-To: <1438159544-6224-10-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oOjl00KHfCxtflTRU3IqmEEkLbTRHLrJd" Subject: Re: [Qemu-devel] [PATCH COLO-Frame v8 09/34] COLO: Add a new RunState RUN_STATE_COLO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Markus Armbruster , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, amit.shah@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oOjl00KHfCxtflTRU3IqmEEkLbTRHLrJd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/29/2015 02:45 AM, zhanghailiang wrote: > Guest will enter this state when paused to save/restore VM state > under colo checkpoint. >=20 > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > --- > qapi-schema.json | 5 ++++- > vl.c | 8 ++++++++ > 2 files changed, 12 insertions(+), 1 deletion(-) Just an interface review. >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index fbbe7f3..6f3e464 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -148,12 +148,15 @@ > # @watchdog: the watchdog action is configured to pause and has been t= riggered > # > # @guest-panicked: guest has been panicked as a result of guest OS pan= ic > +# > +# @colo: guest is paused to save/restore VM state under colo checkpoin= t (since > +# 2.4) Missed 2.4; make this 2.5. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oOjl00KHfCxtflTRU3IqmEEkLbTRHLrJd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV4NmSAAoJEKeha0olJ0Nq1EoH/iPHGYYx8LxkfiEMMkY2A66Z mcdaQdPdBlWT4X7y12orwi5/jE/T4NMvVT8Nv/AtzTYYQ1CBoq7vBCrHx3p77wKg aR11ntTljnTfltQfyQuUtF3U9CNchmpHGJxRrNv0JgrGZQd4plFS9vUdUENJn/vI tIsvnnXEmDnrYF42Q+0mgNqFf5F7cdbPKfGd+rMVYdZxfiF2JAXDJ0srfeaqs3cu nB+QI+WdwqJxBFX2w+sr4nFtMpPZuAPI70bVfZS3OV/UYkTSRLP/g8nTqN3el6Gf CSzfkepxIDqozsIik4150Q88Wf+qphhcFmX1tAlmFrPsqPkPOF3RS9rjCiOhylY= =+cmu -----END PGP SIGNATURE----- --oOjl00KHfCxtflTRU3IqmEEkLbTRHLrJd--