From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVa4Z-0002jZ-Nx for qemu-devel@nongnu.org; Sat, 29 Aug 2015 02:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVa4W-0002Tx-DQ for qemu-devel@nongnu.org; Sat, 29 Aug 2015 02:57:07 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:33126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVa4W-0002TE-60 for qemu-devel@nongnu.org; Sat, 29 Aug 2015 02:57:04 -0400 Received: by wicne3 with SMTP id ne3so2901740wic.0 for ; Fri, 28 Aug 2015 23:57:03 -0700 (PDT) Sender: Paolo Bonzini References: <1439397664-70734-1-git-send-email-pbonzini@redhat.com> <1439397664-70734-8-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <55E157C1.7070101@redhat.com> Date: Sat, 29 Aug 2015 08:57:05 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/10] tcg: comment on which functions have to be called with mmap_lock held List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: mttcg@greensocs.com, QEMU Developers , =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= On 28/08/2015 17:33, Peter Maydell wrote: > Some overall documentation on what the mmap_lock is protecting > (and thus when it needs to be taken) would be nice. > > Otherwise > Reviewed-by: Peter Maydell > > I couldn't see where we take the mmap_lock when we call > tb_gen_code() from tb_find_slow() -- how does that work? It's the bug that's fixed in patch 10. Paolo