From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVa5h-0003fF-Bb for qemu-devel@nongnu.org; Sat, 29 Aug 2015 02:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVa5e-0003Ur-59 for qemu-devel@nongnu.org; Sat, 29 Aug 2015 02:58:17 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:37785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVa5d-0003TX-Tx for qemu-devel@nongnu.org; Sat, 29 Aug 2015 02:58:14 -0400 Received: by wicfv10 with SMTP id fv10so28679920wic.0 for ; Fri, 28 Aug 2015 23:58:13 -0700 (PDT) Sender: Paolo Bonzini References: <1439397664-70734-1-git-send-email-pbonzini@redhat.com> <1439397664-70734-9-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <55E15807.9040701@redhat.com> Date: Sat, 29 Aug 2015 08:58:15 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/10] tcg: add memory barriers in page_find_alloc accesses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: mttcg@greensocs.com, QEMU Developers , =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= On 28/08/2015 17:40, Peter Maydell wrote: > Don't we also need to use an atomic_rcu_read() for the load > pd = *lp; > (which is between hunk 1 and 2 in this patch) ? Yes. Paolo