Re: [Qemu-devel] Mount image file feature

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

On 29.08.2015 20:34, MagicCat Software wrote:
> 
> On Aug 29, 2015, at 2:01 PM, Max Reitz wrote:

[snip]

>> User-friendliness is always expensive,
>> difficult to maintain, and a neverending source of complaints.
> 
> Really? It has been months since Peter Maydell implemented my GUI patches
> for the cocoa interface, and I haven't seen a complaint about it yet.

I just looked into it, and without having an OS X to test it on I have a
few things to complain about:

(1) 'change' always uses 'raw' as the format, but the selector
apparently offers you the full range of image formats
(supportedImageFileTypes).

(2) I think it should be possible to add block devices with removable
media at runtime (I didn't try, though), and also remove them. The
current code doesn't account for that.

(3) supportedImageFileTypes is static. The list might change at any time
and the likelihood of people adding or removing formats there when
adding/removing them to/from the block layer itself is pretty low. Also,
the list depends on compile and (in the future at least) maybe even
runtime options. For instance, it's missing vdi, vhd (vpc), and vhdx.
vhdx in turn can be disabled at compile time.

(4) NSBeep()? Is that necessary? Won't the alert itself be audible if so
desired by the user?

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]