From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49395)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZWHJ5-0001Wd-CV
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 01:07:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZWHJ2-0003pg-6X
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 01:06:59 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:40395)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZWHJ1-0003ox-V8
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 01:06:56 -0400
References: <1438159544-6224-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1438159544-6224-7-git-send-email-zhang.zhanghailiang@huawei.com>
	<55E0D8DA.207@redhat.com>
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
Message-ID: <55E3E0DC.7050808@huawei.com>
Date: Mon, 31 Aug 2015 13:06:36 +0800
MIME-Version: 1.0
In-Reply-To: <55E0D8DA.207@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v8 06/34] migration: Integrate
 COLO checkpoint process into migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, amit.shah@redhat.com

On 2015/8/29 5:55, Eric Blake wrote:
> On 07/29/2015 02:45 AM, zhanghailiang wrote:
>> Add a migrate state: MIGRATION_STATUS_COLO, enter this migration state
>> after the first live migration successfully finished.
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>>   include/migration/colo.h |  3 +++
>>   migration/colo.c         | 58 ++++++++++++++++++++++++++++++++++++++++++++++++
>>   migration/migration.c    | 23 ++++++++++++++-----
>>   qapi-schema.json         |  2 +-
>>   stubs/migration-colo.c   |  9 ++++++++
>>   trace-events             |  3 +++
>>   6 files changed, 92 insertions(+), 6 deletions(-)
>>
>
> Just an interface review.
>
>> +++ b/qapi-schema.json
>> @@ -433,7 +433,7 @@
>>   ##
>>   { 'enum': 'MigrationStatus',
>>     'data': [ 'none', 'setup', 'cancelling', 'cancelled',
>> -            'active', 'completed', 'failed' ] }
>> +            'active', 'completed', 'failed', 'colo' ] }
>
> Missing documentation.
>

Will add in next version, thanks.