From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33729)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZWIIj-0003tL-0t
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 02:10:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZWIIe-0003bC-RF
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 02:10:40 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:3214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZWIIe-0003aE-IM
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 02:10:36 -0400
References: <1438159544-6224-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1438159544-6224-10-git-send-email-zhang.zhanghailiang@huawei.com>
	<55E0D992.40503@redhat.com>
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
Message-ID: <55E3EFB6.8080407@huawei.com>
Date: Mon, 31 Aug 2015 14:09:58 +0800
MIME-Version: 1.0
In-Reply-To: <55E0D992.40503@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v8 09/34] COLO: Add a new
 RunState RUN_STATE_COLO
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Markus Armbruster <armbru@redhat.com>, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, amit.shah@redhat.com

On 2015/8/29 5:58, Eric Blake wrote:
> On 07/29/2015 02:45 AM, zhanghailiang wrote:
>> Guest will enter this state when paused to save/restore VM state
>> under colo checkpoint.
>>
>> Cc: Eric Blake <eblake@redhat.com>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>>   qapi-schema.json | 5 ++++-
>>   vl.c             | 8 ++++++++
>>   2 files changed, 12 insertions(+), 1 deletion(-)
>
> Just an interface review.
>
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index fbbe7f3..6f3e464 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -148,12 +148,15 @@
>>   # @watchdog: the watchdog action is configured to pause and has been triggered
>>   #
>>   # @guest-panicked: guest has been panicked as a result of guest OS panic
>> +#
>> +# @colo: guest is paused to save/restore VM state under colo checkpoint (since
>> +# 2.4)
>
> Missed 2.4; make this 2.5.
>

Will in next version, thanks