From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47227)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZWJBL-0002ix-4F
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 03:07:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZWJBH-0000ZC-3h
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 03:07:07 -0400
Received: from mga03.intel.com ([134.134.136.65]:9958)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZWJBG-0000Z6-Tw
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 03:07:03 -0400
References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1439563931-12352-8-git-send-email-guangrong.xiao@linux.intel.com>
	<20150828172509.GI3819@thinpad.lan.raisama.net>
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Message-ID: <55E3FBB1.2040202@linux.intel.com>
Date: Mon, 31 Aug 2015 15:01:05 +0800
MIME-Version: 1.0
In-Reply-To: <20150828172509.GI3819@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for
	NVDIMM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, rth@twiddle.net


Hi Eduardo,

Thank you for reviewing my patches.

On 08/29/2015 01:25 AM, Eduardo Habkost wrote:
> On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote:
>> NVDIMM reserves all the free range above 4G to do:
>> - Persistent Memory (PMEM) mapping
>> - implement NVDIMM ACPI device _DSM method
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> [...]
>> @@ -1302,6 +1303,7 @@ FWCfgState *pc_memory_init(MachineState *machine,
>>       MemoryRegion *ram_below_4g, *ram_above_4g;
>>       FWCfgState *fw_cfg;
>>       PCMachineState *pcms = PC_MACHINE(machine);
>> +    ram_addr_t offset;
>
> "offset" is a very generic name. I suggest naming it "nvdimm_offset".

'offset' is used for generic proposal as it is not only used for nvdimm but
also for calculating hotplug_mem_base:
       pcms->hotplug_memory.base = ROUND_UP(offset, 1ULL << 30);